[Bug math/19085] New: ldbl-128 lrintl, lroundl missing exceptions for 32-bit long

[Bug math/19085] New: ldbl-128 lrintl, lroundl missing exceptions for 32-bit long

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=19085

            Bug ID: 19085
           Summary: ldbl-128 lrintl, lroundl missing exceptions for 32-bit
                    long
           Product: glibc
           Version: 2.22
            Status: NEW
          Severity: normal
          Priority: P2
         Component: math
          Assignee: unassigned at sourceware dot org
          Reporter: jsm28 at gcc dot gnu.org
  Target Milestone: ---

The ldbl-128 implementations of lrintl and lroundl miss "invalid" exceptions on
systems with 32-bit long for arguments that overflow long but have exponent
below 48.  E.g., for MIPS64 n32:

Failure: lrint (0x1p31): Exception "Invalid operation" not set
Failure: lrint (0x1p32): Exception "Invalid operation" not set
Failure: lrint (0x1p33): Exception "Invalid operation" not set
Failure: lrint (-0x1p32): Exception "Invalid operation" not set
Failure: lrint (-0x1p33): Exception "Invalid operation" not set
Failure: lrint_downward (0x1p31): Exception "Invalid operation" not set
Failure: lrint_downward (0x1p32): Exception "Invalid operation" not set
Failure: lrint_downward (0x1p33): Exception "Invalid operation" not set
Failure: lrint_downward (-0x1p32): Exception "Invalid operation" not set
Failure: lrint_downward (-0x1p33): Exception "Invalid operation" not set
Failure: lrint_towardzero (0x1p31): Exception "Invalid operation" not set
Failure: lrint_towardzero (0x1p32): Exception "Invalid operation" not set
Failure: lrint_towardzero (0x1p33): Exception "Invalid operation" not set
Failure: lrint_towardzero (-0x1p32): Exception "Invalid operation" not set
Failure: lrint_towardzero (-0x1p33): Exception "Invalid operation" not set
Failure: lrint_upward (0x1p31): Exception "Invalid operation" not set
Failure: lrint_upward (0x1p32): Exception "Invalid operation" not set
Failure: lrint_upward (0x1p33): Exception "Invalid operation" not set
Failure: lrint_upward (-0x1p32): Exception "Invalid operation" not set
Failure: lrint_upward (-0x1p33): Exception "Invalid operation" not set
Failure: lround (0x1p31): Exception "Invalid operation" not set
Failure: lround (0x1p32): Exception "Invalid operation" not set
Failure: lround (0x1p33): Exception "Invalid operation" not set
Failure: lround (-0x1p32): Exception "Invalid operation" not set
Failure: lround (-0x1p33): Exception "Invalid operation" not set
Failure: lround_downward (0x1p31): Exception "Invalid operation" not set
Failure: lround_downward (0x1p32): Exception "Invalid operation" not set
Failure: lround_downward (0x1p33): Exception "Invalid operation" not set
Failure: lround_downward (-0x1p32): Exception "Invalid operation" not set
Failure: lround_downward (-0x1p33): Exception "Invalid operation" not set
Failure: lround_towardzero (0x1p31): Exception "Invalid operation" not set
Failure: lround_towardzero (0x1p32): Exception "Invalid operation" not set
Failure: lround_towardzero (0x1p33): Exception "Invalid operation" not set
Failure: lround_towardzero (-0x1p32): Exception "Invalid operation" not set
Failure: lround_towardzero (-0x1p33): Exception "Invalid operation" not set
Failure: lround_upward (0x1p31): Exception "Invalid operation" not set
Failure: lround_upward (0x1p32): Exception "Invalid operation" not set
Failure: lround_upward (0x1p33): Exception "Invalid operation" not set
Failure: lround_upward (-0x1p32): Exception "Invalid operation" not set
Failure: lround_upward (-0x1p33): Exception "Invalid operation" not set

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/19085] ldbl-128 lrintl, lroundl missing exceptions for 32-bit long

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=19085

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  119d073e334e9889a3fd904b333cd13d8217bc58 (commit)
      from  7d6f9f74c8292d63cc3b574eb84919c54946e679 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=119d073e334e9889a3fd904b333cd13d8217bc58

commit 119d073e334e9889a3fd904b333cd13d8217bc58
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Wed Oct 7 16:10:59 2015 +0000

    Fix ldbl-128 lrintl, lroundl missing exceptions for 32-bit long (bug
19085).

    The ldbl-128 implementations of lrintl and lroundl miss "invalid"
    exceptions on systems with 32-bit long for arguments that overflow
    long but have exponent below 48.  This patch fixes this by rearranging
    the sequence of tests in the code so the exponent < 48 case is only
    used for exponents that don't overflow long.

    Tested for mips64 (n32 and n64).

        [BZ #19085]
        * sysdeps/ieee754/ldbl-128/s_lrintl.c (__lrintl): Move test for
        exponent below 48 inside case for non-overflowing exponent.
        * sysdeps/ieee754/ldbl-128/s_lroundl.c (__lroundl): Likewise.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                            |    7 +++++++
 NEWS                                 |    2 +-
 sysdeps/ieee754/ldbl-128/s_lrintl.c  |   24 ++++++++++++------------
 sysdeps/ieee754/ldbl-128/s_lroundl.c |   20 ++++++++++----------
 4 files changed, 30 insertions(+), 23 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug math/19085] ldbl-128 lrintl, lroundl missing exceptions for 32-bit long

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=19085

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.23

--- Comment #2 from Joseph Myers <jsm28 at gcc dot gnu.org> ---
Fixed for 2.23.

-- 
You are receiving this mail because:
You are on the CC list for the bug.