public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sourceware.org Subject: [Bug dynamic-link/19329] dl-tls.c assert failure at concurrent pthread_create and dlopen Date: Tue, 11 May 2021 16:17:25 +0000 [thread overview] Message-ID: <bug-19329-131-BlrBhQnf2J@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-19329-131@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=19329 --- Comment #33 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Szabolcs Nagy <nsz@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=572bd547d57a39b6cf0ea072545dc4048921f4c3 commit 572bd547d57a39b6cf0ea072545dc4048921f4c3 Author: Szabolcs Nagy <szabolcs.nagy@arm.com> Date: Thu Dec 31 13:59:38 2020 +0000 elf: Fix DTV gap reuse logic [BZ #27135] For some reason only dlopen failure caused dtv gaps to be reused. It is possible that the intent was to never reuse modids for a different module, but after dlopen failure all gaps are reused not just the ones caused by the unfinished dlopened. So the code has to handle reused modids already which seems to work, however the data races at thread creation and tls access (see bug 19329 and bug 27111) may be more severe if slots are reused so this is scheduled after those fixes. I think fixing the races are not simpler if reuse is disallowed and reuse has other benefits, so set GL(dl_tls_dtv_gaps) whenever entries are removed from the middle of the slotinfo list. The value does not have to be correct: incorrect true value causes the next modid query to do a slotinfo walk, incorrect false will leave gaps and new entries are added at the end. Fixes bug 27135. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2021-05-11 16:17 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <bug-19329-131@http.sourceware.org/bugzilla/> 2020-05-03 10:56 ` slyfox at inbox dot ru 2020-05-04 13:14 ` nsz at gcc dot gnu.org 2020-05-04 18:25 ` slyfox at inbox dot ru 2020-05-27 17:17 ` sourceware.org@the-compiler.org 2020-05-28 13:15 ` sourceware.org at devrx dot org 2020-07-08 20:15 ` sjkingo88 at gmail dot com 2020-09-09 22:12 ` jg at jguk dot org 2020-09-28 15:27 ` jg at jguk dot org 2020-10-09 10:51 ` jg at jguk dot org 2020-10-09 20:21 ` carlos at redhat dot com 2020-10-12 1:29 ` i.palachev at samsung dot com 2020-10-23 11:47 ` sebastien at debian dot org 2020-10-29 3:12 ` lvying.system.thoughts at gmail dot com 2020-11-11 8:31 ` stli at linux dot ibm.com 2020-12-01 2:15 ` lvying.system.thoughts at gmail dot com 2020-12-24 16:59 ` nsz at gcc dot gnu.org 2021-01-30 15:44 ` azhelev+sourceware at mailbox dot org 2021-02-07 23:04 ` carlos at redhat dot com 2021-02-17 16:00 ` nsz at gcc dot gnu.org 2021-02-23 2:48 ` carlos at redhat dot com 2021-03-15 11:45 ` shanzhikun at gmail dot com 2021-04-20 12:43 ` lilydjwg at gmail dot com 2021-05-11 16:17 ` cvs-commit at gcc dot gnu.org 2021-05-11 16:17 ` cvs-commit at gcc dot gnu.org 2021-05-11 16:17 ` cvs-commit at gcc dot gnu.org [this message] 2021-05-11 16:24 ` nsz at gcc dot gnu.org 2021-09-11 4:54 ` xujing99 at huawei dot com 2021-09-11 5:06 ` xujing99 at huawei dot com 2021-09-11 10:44 ` xujing99 at huawei dot com 2021-09-12 1:23 ` nsz at gcc dot gnu.org 2021-09-13 2:50 ` xujing99 at huawei dot com 2021-09-13 8:25 ` nsz at gcc dot gnu.org 2021-09-16 14:42 ` nsz at gcc dot gnu.org 2021-09-21 13:20 ` nsz at gcc dot gnu.org 2021-10-04 14:12 ` cvs-commit at gcc dot gnu.org 2021-10-19 12:23 ` cvs-commit at gcc dot gnu.org 2023-02-09 12:56 ` louisbenaze at gmail dot com 2023-02-09 13:11 ` jg at jguk dot org 2024-05-16 7:27 ` fweimer at redhat dot com 2024-05-16 7:31 ` fweimer at redhat dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-19329-131-BlrBhQnf2J@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).