public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "i at maskray dot me" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug malloc/23328] Remove malloc hooks and ensure related APIs return no data.
Date: Thu, 05 Aug 2021 18:19:57 +0000	[thread overview]
Message-ID: <bug-23328-131-RiyNGX4xbK@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-23328-131@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=23328

--- Comment #7 from Fangrui Song <i at maskray dot me> ---
(In reply to Fangrui Song from comment #6)
> These hook symbols should also be removed from malloc/Versions .
> The linked output __free_hook@GLIBC_2.2.5 will be unchanged, but it will do
> gold/ld.lld a favor.
> [...]

I added a workaround to ld.lld so that
foo@v1 and (foo or foo@@v1) can be combined: https://reviews.llvm.org/D107235
Good for ld.lld now.

For gold linked libc.so, the dynamic symbol is __free_hook@@GLIBC_2.2.5 because
of PR gold/28196

I think using `.symver *, *, remove` in glibc is the way forward. Created PR
glibc/28197

Once implemented, it can make all linkers happy. (Probably more to GNU ld which
has lots of indirection symbol complexity due to support
https://www.airs.com/blog/archives/220 in a contrived way).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

      parent reply	other threads:[~2021-08-05 18:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-23328-131@http.sourceware.org/bugzilla/>
2021-07-14  2:42 ` siddhesh at sourceware dot org
2021-07-22 13:19 ` siddhesh at sourceware dot org
2021-07-30  7:15 ` i at maskray dot me
2021-08-05 18:19 ` i at maskray dot me [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-23328-131-RiyNGX4xbK@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).