From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 96AEA398C823; Fri, 2 Oct 2020 09:46:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 96AEA398C823 From: "fweimer at redhat dot com" To: glibc-bugs@sourceware.org Subject: [Bug libc/23960] [2.28 Regression]: New getdents{64} implementation breaks qemu-user Date: Fri, 02 Oct 2020 09:46:51 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: libc X-Bugzilla-Version: 2.28 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: fweimer at redhat dot com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: security- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: glibc-bugs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-bugs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Oct 2020 09:46:51 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D23960 --- Comment #60 from Florian Weimer --- (In reply to Danny Milosavljevic from comment #59) > It's impossible to store a 64 bit result into a 32 bit slot. You can do something like that if you can maintain a translation table. The kernel cannot do it due to the way the getdents64 system call works. glibc = can do it for telldir/seekdir (allocating table slots on demand), which are the interfaces that are actually problematic. > Please don't use SYS_getdents. Just please mandate LFS instead. This sh= ould have been done long (decades) ago. LFS does not change the return type of telldir. So it does not fix the issu= e. We need to maintain a translation table for telldir and seekdir in DIR. It = can be filled on demand, so that applications that do not call telldir are pret= ty much unaffected. The only thing that is a bit tricky is that we have to pre-allocate the slot during readdir because telldir must not fail. --=20 You are receiving this mail because: You are on the CC list for the bug.=