public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug nss/26233] matchpathcon and security_context_t are deprecated by libselinux API
Date: Mon, 12 Sep 2022 22:28:10 +0000	[thread overview]
Message-ID: <bug-26233-131-2pdupYZo7w@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-26233-131@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=26233

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Carlos O'Donell <carlos@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f278835f594740f5913001430641cf1da4878670

commit f278835f594740f5913001430641cf1da4878670
Author: Aurelien Jarno <aurelien@aurel32.net>
Date:   Sun Sep 11 11:30:17 2022 -0400

    makedb: fix build with libselinux >= 3.1 (Bug 26233)

    glibc doesn't build with libselinux 3.1 that has been released recently
    due to new deprecations introduced in that version and the fact that
    glibc is built with -Werror by default:

    | makedb.c: In function âset_file_creation_contextâ:
    | makedb.c:849:3: error: âsecurity_context_tâ is deprecated
[-Werror=deprecated-declarations]
    |   849 |   security_context_t ctx;
    |       |   ^~~~~~~~~~~~~~~~~~
    | makedb.c:863:3: error: âmatchpathconâ is deprecated: Use
selabel_lookup instead [-Werror=deprecated-declarations]
    |   863 |   if (matchpathcon (outname, S_IFREG | mode, &ctx) == 0 && ctx !=
NULL)
    |       |   ^~
    | In file included from makedb.c:50:
    | /usr/include/selinux/selinux.h:500:12: note: declared here
    |   500 | extern int matchpathcon(const char *path,
    |       |            ^~~~~~~~~~~~
    | cc1: all warnings being treated as errors

    This patch fixes the makedb half of bug 26233 by moving to the new
    SELinux APIs and removes the existing compiler pragmas as no longer
    required. Upstream API usage feedback gathered by Arjun is integrated
    into this version of the fix.

    The built makedb was tested and operates as expected on x86_64 with
    SELinu in enforcing mode.

    No regressions on x86_64 with libselinux 3.3.

    Co-authored-by: Arjun Shankar <arjun@redhat.com>
    Co-authored-by: Carlos O'Donell <carlos@redhat.com>
    Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2022-09-12 22:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-13 13:09 [Bug nss/26233] New: " arjun.is at lostca dot se
2020-07-13 13:10 ` [Bug nss/26233] " arjun.is at lostca dot se
2020-07-16 15:25 ` jsegitz at suse dot de
2020-07-21 11:20 ` fweimer at redhat dot com
2020-07-21 11:43 ` glaubitz at physik dot fu-berlin.de
2020-07-21 11:48 ` glaubitz at physik dot fu-berlin.de
2020-07-21 11:52 ` schwab@linux-m68k.org
2020-07-22 21:18 ` arjun.is at lostca dot se
2020-07-23 10:39 ` arjun.is at lostca dot se
2022-09-12 22:28 ` cvs-commit at gcc dot gnu.org [this message]
2022-09-12 22:30 ` carlos at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-26233-131-2pdupYZo7w@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).