From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id AF6AC3851C17; Wed,  5 Aug 2020 14:08:24 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AF6AC3851C17
From: "fweimer at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug build/26338] io/tst-copy_file_range fails on RHEL 7.8 hosts
Date: Wed, 05 Aug 2020 14:08:24 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: glibc
X-Bugzilla-Component: build
X-Bugzilla-Version: 2.33
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: fweimer at redhat dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-26338-131-HDSMRDByry@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-26338-131@http.sourceware.org/bugzilla/>
References: <bug-26338-131@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: glibc-bugs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Glibc-bugs mailing list <glibc-bugs.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/glibc-bugs>,
 <mailto:glibc-bugs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/glibc-bugs/>
List-Help: <mailto:glibc-bugs-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/glibc-bugs>,
 <mailto:glibc-bugs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Aug 2020 14:08:24 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D26338

--- Comment #5 from Florian Weimer <fweimer at redhat dot com> ---
(In reply to Adhemerval Zanella from comment #4)
> So I don't think ENOSYS as RHEL 7.8 is doing is the correct way to advert=
ise
> the syscall does not work depending of the underlying filesystem (at least
> it seems not what upstream is doing).

It would break cp from coreutils, which only recognizes ENOSYS, EINVAL, EBA=
DF,
EXDEV as soft errors.

The EOPNOTSUPPs you listed should not leak into userspace because they trig=
ger
generic splice-based copy_file_range fallback, and splice apparently fails =
with
EINVAL in case of missing file system support.

It's true that ENOSYS breaks programs that cache the availability of the sy=
stem
call and assume that the error is parameter-independent. EINVAL might have =
been
the better choice for that reason.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=