public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "siddhesh at sourceware dot org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug locale/26923] Assertion failure in iconv when converting invalid UCS4 (CVE-2020-29562)
Date: Mon, 07 Dec 2020 17:19:39 +0000	[thread overview]
Message-ID: <bug-26923-131-SQQ0h8oAzd@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-26923-131@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=26923

Siddhesh Poyarekar <siddhesh at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.33

--- Comment #5 from Siddhesh Poyarekar <siddhesh at sourceware dot org> ---
Fixed in master.

commit 228edd356f03bf62dcf2b1335f25d43c602ee68d
Author: Michael Colavita <mcolavita@fb.com>
Date:   Thu Nov 19 11:44:40 2020 -0500

    iconv: Fix incorrect UCS4 inner loop bounds (BZ#26923)

    Previously, in UCS4 conversion routines we limit the number of
    characters we examine to the minimum of the number of characters in the
    input and the number of characters in the output. This is not the
    correct behavior when __GCONV_IGNORE_ERRORS is set, as we do not consume
    an output character when we skip a code unit. Instead, track the input
    and output pointers and terminate the loop when either reaches its
    limit.

    This resolves assertion failures when resetting the input buffer in a step
of
    iconv, which assumes that the input will be fully consumed given sufficient
    output space.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2020-12-07 17:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19 18:22 [Bug locale/26923] New: Assertion failure in iconv when converting invalid UCS4 mcolavita at fb dot com
2020-11-19 18:40 ` [Bug locale/26923] " carlos at redhat dot com
2020-11-19 18:42 ` mcolavita at fb dot com
2020-11-19 18:43 ` carlos at redhat dot com
2020-11-19 21:06 ` P at draigBrady dot com
2020-11-20  8:22 ` siddhesh at sourceware dot org
2020-12-04 14:11 ` carnil at debian dot org
2020-12-07 16:54 ` [Bug locale/26923] Assertion failure in iconv when converting invalid UCS4 (CVE-2020-29562) siddhesh at sourceware dot org
2020-12-07 17:19 ` siddhesh at sourceware dot org [this message]
2020-12-08 14:35 ` cvs-commit at gcc dot gnu.org
2021-01-03 13:47 ` cvs-commit at gcc dot gnu.org
2021-09-21  0:54 ` cvs-commit at gcc dot gnu.org
2022-10-07  8:20 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-26923-131-SQQ0h8oAzd@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).