[Bug dynamic-link/27046] glibc-hwcaps priority matching fails on cache entry flags mismatch

["fweimer at redhat dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=27046

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.34
             Status|ASSIGNED                    |RESOLVED

--- Comment #9 from Florian Weimer <fweimer at redhat dot com> ---
Fixed for glibc 2.34 via:

commit 66db95b6e8264c5a6307f6a9e5285fec76907254
Author: Florian Weimer <fweimer@redhat.com>
Date:   Fri Jun 25 08:02:30 2021 +0200

    elf: Fix glibc-hwcaps priorities with cache flags mismatches [BZ #27046]

    If lib->flags (in the cache) did not match GLRO (dl_correct_cache_id),
    searching for further glibc-hwcaps entries did not happen, and it
    was possible that the best glibc-hwcaps was not found.  By accident,
    this causes a test failure for elf/tst-glibc-hwcaps-prepend-cache
    on armv7l.

    This commit changes the cache lookup logic to continue searching
    if (a) no match has been found, (b) a named glibc-hwcaps match
    has been found(), or (c) non-glibc-hwcaps match has been found
    and the entry flags and cache default flags do not match.

    _DL_CACHE_DEFAULT_ID is used instead of GLRO (dl_correct_cache_id)
    because the latter is only written once on i386 if loading
    of libc.so.5 libraries is selected, so GLRO (dl_correct_cache_id)
    should probably removed in a future change.

    Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.