public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "siddhesh at sourceware dot org" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sourceware.org Subject: [Bug libc/27083] New: Unsafe unbounded alloca in addmntent Date: Wed, 16 Dec 2020 14:12:55 +0000 [thread overview] Message-ID: <bug-27083-131@http.sourceware.org/bugzilla/> (raw) https://sourceware.org/bugzilla/show_bug.cgi?id=27083 Bug ID: 27083 Summary: Unsafe unbounded alloca in addmntent Product: glibc Version: unspecified Status: NEW Severity: normal Priority: P2 Component: libc Assignee: unassigned at sourceware dot org Reporter: siddhesh at sourceware dot org CC: drepper.fsp at gmail dot com Target Milestone: --- addmntent duplicates strings in its input struct mntent using alloca due to which very long strings could blow up the stack. Example: #include <stdlib.h> #include <mntent.h> #include <stdio.h> #include <string.h> #define LARGE_VALUE 2*1024*1024*1024ULL int main(int argc, char **argv) { FILE *f = fopen("/dev/null", "w"); struct mntent bad; bad.mnt_fsname = calloc (LARGE_VALUE, 1); memset (bad.mnt_fsname, ' ', LARGE_VALUE - 1); bad.mnt_dir = calloc (LARGE_VALUE, 1); memset (bad.mnt_dir, ' ', LARGE_VALUE - 1); bad.mnt_type = calloc (LARGE_VALUE, 1); memset (bad.mnt_type, ' ', LARGE_VALUE - 1); bad.mnt_opts = calloc (LARGE_VALUE, 1); memset (bad.mnt_opts, ' ', LARGE_VALUE - 1); bad.mnt_freq = 1; bad.mnt_passno = 2; addmntent (f, &bad); endmntent(f); return 0; } -- You are receiving this mail because: You are on the CC list for the bug.
next reply other threads:[~2020-12-16 14:12 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-16 14:12 siddhesh at sourceware dot org [this message] 2020-12-16 14:18 ` [Bug libc/27083] " siddhesh at sourceware dot org 2020-12-16 16:32 ` siddhesh at sourceware dot org 2020-12-18 16:04 ` siddhesh at sourceware dot org 2020-12-22 16:05 ` siddhesh at sourceware dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-27083-131@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).