public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "joseph at codesourcery dot com" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sourceware.org Subject: [Bug localedata/27320] localedata/gen-locale.sh failure in native build is ignored Date: Wed, 03 Feb 2021 21:13:02 +0000 [thread overview] Message-ID: <bug-27320-131-mbgTxK3cGy@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-27320-131@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=27320 --- Comment #8 from joseph at codesourcery dot com <joseph at codesourcery dot com> --- An appropriate fix would be to make any failure in localedata/gen-locale.sh produce a FAIL for the generated locale. The first step in that is that gen-locale.sh should exit with error status on error from localedef, which it looks to me like it does (an explicit "exit 1"). The second step is that the makefile rule should use $(evaluate-test), which it also does (in gen-locales.mk). So there are a few other issues to resolve: * The locales should be listed in tests-special (like how timezone/Makefile does tests-special += $(addprefix $(testdata)/, $(test-zones)) to get files built by zic listed as tests, for example). * That listing in tests-special probably needs to be in the localedata/ directory as that's where the files in question are built. * Then the FAIL would be in localedata/subdir-tests.sum. * But you're using subdirs=string which prevents FAILs outside string/subdir-tests.sum from being considered in the process of merging FAILs from subdirectories. Fixing the points above should ensure a FAIL when gen-locale.sh fails in a full testsuite run, but getting one if you're only building a non-localedata subdirectory may be harder. -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2021-02-03 21:13 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-02 20:30 [Bug localedata/27320] New: localedata/gen-locale.sh failure " hjl.tools at gmail dot com 2021-02-02 20:42 ` [Bug localedata/27320] " fweimer at redhat dot com 2021-02-02 21:02 ` hjl.tools at gmail dot com 2021-02-02 23:07 ` joseph at codesourcery dot com 2021-02-02 23:11 ` hjl.tools at gmail dot com 2021-02-03 8:46 ` schwab@linux-m68k.org 2021-02-03 19:20 ` joseph at codesourcery dot com 2021-02-03 20:13 ` [Bug localedata/27320] localedata/gen-locale.sh failure in native build " hjl.tools at gmail dot com 2021-02-03 21:13 ` joseph at codesourcery dot com [this message] 2021-02-03 21:34 ` hjl.tools at gmail dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-27320-131-mbgTxK3cGy@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).