public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "fweimer at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/27398] x86: Improve testing false positive for tst-cpu-features-cpuinfo with bad hardware.
Date: Mon, 02 May 2022 10:42:38 +0000 [thread overview]
Message-ID: <bug-27398-131-NHWW0TSk0G@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-27398-131@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=27398
Florian Weimer <fweimer at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |MOVED
Status|REOPENED |RESOLVED
--- Comment #32 from Florian Weimer <fweimer at redhat dot com> ---
(In reply to Siddhesh Poyarekar from comment #3)
> It only reports failures on cpu0, on every run, none of the other cores:
>
> $ taskset --cpu-list 0 ./testrun.sh elf/tst-cpu-features-cpuinfo | grep -B 3
> fail
> Checking HAS_CPU_FEATURE (HLE):
> HAS_CPU_FEATURE (HLE): 1
> cpuinfo (hle): 0
> *** failure ***
> --
> Checking HAS_CPU_FEATURE (RTM):
> HAS_CPU_FEATURE (RTM): 1
> cpuinfo (rtm): 0
> *** failure ***
This was fixed as a kernel bug:
commit e2a1256b17b16f9b9adf1b6fea56819e7b68e463
Author: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
Date: Mon Apr 4 17:35:45 2022 -0700
x86/speculation: Restore speculation related MSRs during S3 resume
After resuming from suspend-to-RAM, the MSRs that control CPU's
speculative execution behavior are not being restored on the boot CPU.
These MSRs are used to mitigate speculative execution vulnerabilities.
Not restoring them correctly may leave the CPU vulnerable. Secondary
CPU's MSRs are correctly being restored at S3 resume by
identify_secondary_cpu().
During S3 resume, restore these MSRs for boot CPU when restoring its
processor state.
Fixes: 772439717dbf ("x86/bugs/intel: Set proper CPU features and setup
RDS")
Reported-by: Neelima Krishnan <neelima.krishnan@intel.com>
Signed-off-by: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
Tested-by: Neelima Krishnan <neelima.krishnan@intel.com>
Acked-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Dave Hansen <dave.hansen@linux.intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Leaving this bug here at security- because it's not a glibc bug (disabling RTM
for glibc's own use does not mitigate the vulnerability).
--
You are receiving this mail because:
You are on the CC list for the bug.
prev parent reply other threads:[~2022-05-02 10:42 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 4:44 [Bug libc/27398] New: Sporadic failures in tst-cpu-features-cpuinfo siddhesh at sourceware dot org
2021-02-12 4:52 ` [Bug libc/27398] " siddhesh at sourceware dot org
2021-02-12 9:46 ` [Bug libc/27398] x86: " fweimer at redhat dot com
2021-02-12 9:59 ` siddhesh at sourceware dot org
2021-02-12 13:45 ` hjl.tools at gmail dot com
2021-02-12 13:51 ` hjl.tools at gmail dot com
2021-02-12 14:00 ` siddhesh at sourceware dot org
2022-01-14 22:20 ` carlos at redhat dot com
2022-01-14 22:21 ` [Bug libc/27398] x86: Improve testing false positive for tst-cpu-features-cpuinfo with bad hardware carlos at redhat dot com
2022-01-14 22:26 ` hjl.tools at gmail dot com
2022-01-14 22:57 ` hjl.tools at gmail dot com
2022-01-14 22:57 ` hjl.tools at gmail dot com
2022-01-17 14:09 ` carlos at redhat dot com
2022-01-17 15:17 ` hjl.tools at gmail dot com
2022-01-17 15:17 ` hjl.tools at gmail dot com
2022-01-18 3:49 ` carlos at redhat dot com
2022-01-18 3:50 ` carlos at redhat dot com
2022-01-18 14:22 ` hjl.tools at gmail dot com
2022-01-18 14:24 ` hjl.tools at gmail dot com
2022-01-18 16:17 ` carlos at redhat dot com
2022-01-18 16:32 ` hjl.tools at gmail dot com
2022-01-18 16:35 ` carlos at redhat dot com
2022-01-18 16:38 ` carlos at redhat dot com
2022-01-18 22:21 ` cvs-commit at gcc dot gnu.org
2022-01-18 22:22 ` hjl.tools at gmail dot com
2022-01-25 18:19 ` carlos at redhat dot com
2022-01-25 18:41 ` hjl.tools at gmail dot com
2022-01-25 18:42 ` hjl.tools at gmail dot com
2022-01-26 19:30 ` carlos at redhat dot com
2022-02-01 13:54 ` cvs-commit at gcc dot gnu.org
2022-02-01 14:08 ` cvs-commit at gcc dot gnu.org
2022-02-01 15:26 ` cvs-commit at gcc dot gnu.org
2022-02-01 15:36 ` cvs-commit at gcc dot gnu.org
2022-02-01 15:59 ` cvs-commit at gcc dot gnu.org
2022-02-01 16:06 ` cvs-commit at gcc dot gnu.org
2022-02-01 17:16 ` cvs-commit at gcc dot gnu.org
2022-05-02 10:42 ` fweimer at redhat dot com [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-27398-131-NHWW0TSk0G@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=glibc-bugs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).