From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id E27C63858D33; Mon, 2 May 2022 10:42:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E27C63858D33 From: "fweimer at redhat dot com" To: glibc-bugs@sourceware.org Subject: [Bug libc/27398] x86: Improve testing false positive for tst-cpu-features-cpuinfo with bad hardware. Date: Mon, 02 May 2022 10:42:38 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: libc X-Bugzilla-Version: 2.35 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: fweimer at redhat dot com X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: MOVED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: hjl.tools at gmail dot com X-Bugzilla-Target-Milestone: 2.35 X-Bugzilla-Flags: security- X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: glibc-bugs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-bugs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2022 10:42:39 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D27398 Florian Weimer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |MOVED Status|REOPENED |RESOLVED --- Comment #32 from Florian Weimer --- (In reply to Siddhesh Poyarekar from comment #3) > It only reports failures on cpu0, on every run, none of the other cores: >=20 > $ taskset --cpu-list 0 ./testrun.sh elf/tst-cpu-features-cpuinfo | grep -= B 3 > fail > Checking HAS_CPU_FEATURE (HLE): > HAS_CPU_FEATURE (HLE): 1 > cpuinfo (hle): 0 > *** failure *** > -- > Checking HAS_CPU_FEATURE (RTM): > HAS_CPU_FEATURE (RTM): 1 > cpuinfo (rtm): 0 > *** failure *** This was fixed as a kernel bug: commit e2a1256b17b16f9b9adf1b6fea56819e7b68e463 Author: Pawan Gupta Date: Mon Apr 4 17:35:45 2022 -0700 x86/speculation: Restore speculation related MSRs during S3 resume After resuming from suspend-to-RAM, the MSRs that control CPU's speculative execution behavior are not being restored on the boot CPU. These MSRs are used to mitigate speculative execution vulnerabilities. Not restoring them correctly may leave the CPU vulnerable. Secondary CPU's MSRs are correctly being restored at S3 resume by identify_secondary_cpu(). During S3 resume, restore these MSRs for boot CPU when restoring its processor state. Fixes: 772439717dbf ("x86/bugs/intel: Set proper CPU features and setup RDS") Reported-by: Neelima Krishnan Signed-off-by: Pawan Gupta Tested-by: Neelima Krishnan Acked-by: Borislav Petkov Reviewed-by: Dave Hansen Cc: stable@vger.kernel.org Signed-off-by: Linus Torvalds Leaving this bug here at security- because it's not a glibc bug (disabling = RTM for glibc's own use does not mitigate the vulnerability). --=20 You are receiving this mail because: You are on the CC list for the bug.=