From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 20BE43858006; Tue, 18 Jan 2022 03:49:53 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 20BE43858006
From: "carlos at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/27398] x86: Improve testing false positive for
 tst-cpu-features-cpuinfo with bad hardware.
Date: Tue, 18 Jan 2022 03:49:52 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: glibc
X-Bugzilla-Component: libc
X-Bugzilla-Version: 2.35
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: carlos at redhat dot com
X-Bugzilla-Status: WAITING
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: hjl.tools at gmail dot com
X-Bugzilla-Target-Milestone: 2.35
X-Bugzilla-Flags: security-
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-27398-131-cPk2dqjIrr@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-27398-131@http.sourceware.org/bugzilla/>
References: <bug-27398-131@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: glibc-bugs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Glibc-bugs mailing list <glibc-bugs.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/glibc-bugs>,
 <mailto:glibc-bugs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/glibc-bugs/>
List-Help: <mailto:glibc-bugs-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/glibc-bugs>,
 <mailto:glibc-bugs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Jan 2022 03:49:53 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D27398

--- Comment #12 from Carlos O'Donell <carlos at redhat dot com> ---
(In reply to H.J. Lu from comment #11)
> Created attachment 13910 [details]
> The v2 patch
>=20
> Please try this.

Thanks HJ.

My apologies, I made a mistake during testing, this still fails:

[carlos@fedora ~]$ taskset --cpu-list 0,1 ~/build/glibc-review/testrun.sh
/home/carlos/build/glibc-review/elf/tst-cpu-features-cpuinfo-static; echo $?

Checking HAS_CPU_FEATURE (HLE):
  HAS_CPU_FEATURE (HLE): 1
  cpuinfo (hle): 0
 *** failure ***

Checking HAS_CPU_FEATURE (RTM):
  HAS_CPU_FEATURE (RTM): 1
  cpuinfo (rtm): 0
 *** failure ***

Likewise:

[carlos@fedora ~]$ taskset --cpu-list 0,1 ~/build/glibc-review/testrun.sh
/home/carlos/build/glibc-review/string/tst-memchr-rtm; echo $?
error: ../sysdeps/x86/tst-string-rtm.h:63: TSX abort rate: 100.00% (3000 ou=
t of
3000)
error: 1 test failures
1
[carlos@fedora ~]$ taskset --cpu-list 0,1 ~/build/glibc-review/testrun.sh
/home/carlos/build/glibc-review/string/tst-memchr-rtm; echo $?
77

[carlos@fedora ~]$ taskset --cpu-list 0,1 ~/build/glibc-review-i686/testrun=
.sh
/home/carlos/build/glibc-review-i686/string/tst-memchr-rtm; echo $?
77
[carlos@fedora ~]$ taskset --cpu-list 0,1 ~/build/glibc-review-i686/testrun=
.sh
/home/carlos/build/glibc-review-i686/string/tst-memchr-rtm; echo $?
error: ../sysdeps/x86/tst-string-rtm.h:63: TSX abort rate: 100.00% (3000 ou=
t of
3000)
error: 1 test failures
1

--=20
You are receiving this mail because:
You are on the CC list for the bug.=