public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "fweimer at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug nss/27416] __nss_database_lookup2 ignores defconfig and alternate_name
Date: Mon, 10 Jan 2022 12:37:31 +0000	[thread overview]
Message-ID: <bug-27416-131-duL4XmelmC@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-27416-131@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=27416

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.34
         Resolution|---                         |FIXED
              Flags|                            |security-
                 CC|                            |fweimer at redhat dot com
             Status|NEW                         |RESOLVED

--- Comment #3 from Florian Weimer <fweimer at redhat dot com> ---
Thanks for the suggestion.

Fixed for 2.34 using:

commit 9b456c5da968ee832ea4b2b73a18a5bf6d2118a6
Author: DJ Delorie <dj@redhat.com>
Date:   Mon Feb 15 21:34:23 2021 -0500

    nss: fix nss_database_lookup2's alternate handling [BZ #27416]

    __nss_database_lookup2's extra arguments were left unused in the
    nsswitch reloading patch set; this broke compat (default config
    ignored) and shadow files (secondary name ignored) which relies on
    these fallbacks.

    This patch adds in the previous behavior by correcting the
    initialization of the database list to reflect the fallbacks.  This
    means that the nss_database_lookup2 interface no longer needs to be
    passed the fallback info, so API and callers were adjusted.

    Since all callers needed to be edited anyway, the calls were changed
    from __nss_database_lookup2 to the faster __nss_database_get.  This
    was an intended optimization which was deferred during the initial
    lookup changes to avoid touching so many files.

    The test case verifies that compat targets work (passwd) and that the
    default configuration works (group).  Tested on x86-64.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

      parent reply	other threads:[~2022-01-10 12:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-14 19:58 [Bug nss/27416] New: __nss_database_lookup2 ignores defconfig schwab@linux-m68k.org
2021-02-14 20:05 ` [Bug nss/27416] __nss_database_lookup2 ignores defconfig and alternate_name schwab@linux-m68k.org
2022-01-09 21:38 ` aurelien at aurel32 dot net
2022-01-10 12:37 ` fweimer at redhat dot com [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-27416-131-duL4XmelmC@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).