public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "carlos at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug dynamic-link/27609] New: In elf/dl-open.c (_dl_open) we might use __LM_ID_CALLER to index GL(dl_ns)[]
Date: Thu, 18 Mar 2021 18:55:42 +0000	[thread overview]
Message-ID: <bug-27609-131@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=27609

            Bug ID: 27609
           Summary: In elf/dl-open.c (_dl_open) we might use
                    __LM_ID_CALLER to index GL(dl_ns)[]
           Product: glibc
           Version: 2.33
            Status: NEW
          Severity: normal
          Priority: P2
         Component: dynamic-link
          Assignee: unassigned at sourceware dot org
          Reporter: carlos at redhat dot com
  Target Milestone: ---

AFAICT we *might* get here with an __LM_ID_CALLER value... and using -2 into
the index would not yield the expected result.

881       /* Avoid keeping around a dangling reference to the libc.so link
882          map in case it has been cached in libc_map.  */
883       if (!args.libc_already_loaded)
884         GL(dl_ns)[nsid].libc_map = NULL;
885 

We should review this and ensure we can never get __LM_ID_CALLER here, or that
if we can that it should be OK.

It doesn't look we get here because of the guard !args.libc_already_loaded, but
I could be wrong so I'm filling this bug to check on that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2021-03-18 18:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-18 18:55 carlos at redhat dot com [this message]
2021-08-17 18:31 ` [Bug dynamic-link/27609] " hjl.tools at gmail dot com
2021-09-30 17:19 ` [Bug dynamic-link/27609] [2.32/2.33/2.34 Regression] " hjl.tools at gmail dot com
2021-09-30 19:41 ` cvs-commit at gcc dot gnu.org
2021-10-13 12:29 ` cvs-commit at gcc dot gnu.org
2021-10-13 12:57 ` cvs-commit at gcc dot gnu.org
2021-10-13 14:10 ` cvs-commit at gcc dot gnu.org
2021-10-13 14:11 ` hjl.tools at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-27609-131@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).