public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "daniel at mariadb dot org" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sourceware.org Subject: [Bug network/27634] New: getnameinfo on abstract socket fails to populate serv with a name Date: Tue, 23 Mar 2021 11:16:42 +0000 [thread overview] Message-ID: <bug-27634-131@http.sourceware.org/bugzilla/> (raw) https://sourceware.org/bugzilla/show_bug.cgi?id=27634 Bug ID: 27634 Summary: getnameinfo on abstract socket fails to populate serv with a name Product: glibc Version: 2.34 Status: UNCONFIRMED Severity: normal Priority: P2 Component: network Assignee: unassigned at sourceware dot org Reporter: daniel at mariadb dot org Target Milestone: --- gni_serv_local uses checked_copy which uses memcpy to create the destination name derived from strlen. With abstract sockets however the serv starts with '\0', according to unix(7) can contain '\0'. This leads to a rather serv description. Its hard to say what the desired behavior is as the serv is a null string on the API. A memcpy of the real length is probably a start. My solution currently has some assumptions (however its good enough for me). getnameinfo_err= getnameinfo(&addr.sa, addrlen, hbuf, sizeof(hbuf), sbuf, sizeof(sbuf), NI_NUMERICHOST | NI_NUMERICSERV); if (getnameinfo_err) sql_print_warning("getnameinfo() on systemd socket activation socket %d" " failed with error %d", fd, getnameinfo_err); else { /* handle abstract sockets and present them in @ form */ if (sbuf[0] == '\0') addr.un.sun_path[0] = '@'; sql_print_information("Using systemd activated socket %s port %s", hbuf, sbuf[0] == '\0' ? addr.un.sun_path : sbuf); } -- You are receiving this mail because: You are on the CC list for the bug.
next reply other threads:[~2021-03-23 11:16 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-23 11:16 daniel at mariadb dot org [this message] 2021-03-24 0:12 ` [Bug network/27634] " daniel at mariadb dot org 2021-03-27 5:32 ` daniel at mariadb dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-27634-131@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).