[Bug libc/27735] New: memusagestat with GiB or TiB of RAM axis values can be clipped

["paul at preney dot ca" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=27735

            Bug ID: 27735
           Summary: memusagestat with GiB or TiB of RAM axis values can be
                    clipped
           Product: glibc
           Version: 2.33
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: paul at preney dot ca
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

Created attachment 13371
  --> https://sourceware.org/bugzilla/attachment.cgi?id=13371&action=edit
memusagestat-large-values.patch

Using memusagestat with collected data from systems that have of GiB of RAM or
more can result in the heap axis' values being clipped since they are too
large/long for the space provided. Additionally such values should be
abbreviated using G (for giga) and T for (tera) and scaled as the other values
are. The requires the _scale values to be declared as site_t (or some type
larger than int) and ULL used with the constant values (e.g., 100ULL * 1024 *
1024 * 1024, etc.) so they result in not-always-false if tests.

While cosmetic, I have also adjusted the colour values which were too bright
against the bright grey (almost white) background to provide more contrast. I
also made the background colour not transparent since it can make the graph
very hard-to-read on non-white underlying backgrounds. I avoided making any
other changes. (The colours and transparency changes are simple edits involving
4 lines of code.)

ASIDE: I colour shifted the blue to be a dark cyan to allow it to be more
easily seen as different from black. Pure blue is harder to see unless bright
--but when bright it is harder to see against the background.

These changes can be seen in the attached patch file:
memusagestat-large-values.patch . :-)

(While I used v2.33 this affects all versions of glibc with memusagestat.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.