From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 092DF3886C7B; Thu, 15 Apr 2021 17:50:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 092DF3886C7B From: "paul at preney dot ca" To: glibc-bugs@sourceware.org Subject: [Bug libc/27735] New: memusagestat with GiB or TiB of RAM axis values can be clipped Date: Thu, 15 Apr 2021 17:50:44 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: libc X-Bugzilla-Version: 2.33 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: paul at preney dot ca X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter cc target_milestone attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: glibc-bugs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-bugs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Apr 2021 17:50:45 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D27735 Bug ID: 27735 Summary: memusagestat with GiB or TiB of RAM axis values can be clipped Product: glibc Version: 2.33 Status: UNCONFIRMED Severity: normal Priority: P2 Component: libc Assignee: unassigned at sourceware dot org Reporter: paul at preney dot ca CC: drepper.fsp at gmail dot com Target Milestone: --- Created attachment 13371 --> https://sourceware.org/bugzilla/attachment.cgi?id=3D13371&action=3Ded= it memusagestat-large-values.patch Using memusagestat with collected data from systems that have of GiB of RAM= or more can result in the heap axis' values being clipped since they are too large/long for the space provided. Additionally such values should be abbreviated using G (for giga) and T for (tera) and scaled as the other val= ues are. The requires the _scale values to be declared as site_t (or some type larger than int) and ULL used with the constant values (e.g., 100ULL * 1024= * 1024 * 1024, etc.) so they result in not-always-false if tests. While cosmetic, I have also adjusted the colour values which were too bright against the bright grey (almost white) background to provide more contrast.= I also made the background colour not transparent since it can make the graph very hard-to-read on non-white underlying backgrounds. I avoided making any other changes. (The colours and transparency changes are simple edits invol= ving 4 lines of code.) ASIDE: I colour shifted the blue to be a dark cyan to allow it to be more easily seen as different from black. Pure blue is harder to see unless brig= ht --but when bright it is harder to see against the background. These changes can be seen in the attached patch file: memusagestat-large-values.patch . :-) (While I used v2.33 this affects all versions of glibc with memusagestat.) --=20 You are receiving this mail because: You are on the CC list for the bug.=