public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "nsz at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/27824] New: preadv2 and pwritev2 offset argument passing on 64bit targets
Date: Tue, 04 May 2021 14:56:05 +0000	[thread overview]
Message-ID: <bug-27824-131@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=27824

            Bug ID: 27824
           Summary: preadv2 and pwritev2 offset argument passing on 64bit
                    targets
           Product: glibc
           Version: 2.33
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: nsz at gcc dot gnu.org
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

the linux preadv2 offset arg passing code is

/* Provide a macro to pass the off{64}_t argument on p{readv,writev}{64}.  */
#define LO_HI_LONG(val) \
 (long) (val), \
 (long) (((uint64_t) (val)) >> 32)

on a 64bit target the first arg contains the entire 64bit offset
but i'd expect the second arg to be fixed 0.

linux does not seem to look at the second arg now on 64bit targets,
but it seems cleaner to pass 0 instead of top 32bit of val.

x86_64 seems to fixed this but other targets still have the >> 32
logic.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2021-05-04 14:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-04 14:56 nsz at gcc dot gnu.org [this message]
2021-05-04 15:21 ` [Bug libc/27824] " schwab@linux-m68k.org
2021-05-04 17:29 ` adhemerval.zanella at linaro dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-27824-131@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).