public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug libc/27892] New: powerpc: scv ABI error handling fails to check IS_ERR_VALUE
@ 2021-05-20 14:23 ldv at sourceware dot org
2021-05-20 21:28 ` [Bug libc/27892] " tuliom at ascii dot art.br
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: ldv at sourceware dot org @ 2021-05-20 14:23 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=27892
Bug ID: 27892
Summary: powerpc: scv ABI error handling fails to check
IS_ERR_VALUE
Product: glibc
Version: 2.33
URL: https://sourceware.org/pipermail/libc-alpha/2021-May/1
26534.html
Status: NEW
Severity: normal
Priority: P2
Component: libc
Assignee: unassigned at sourceware dot org
Reporter: ldv at sourceware dot org
CC: drepper.fsp at gmail dot com
Target Milestone: ---
Commit glibc-2.33~117 introduced RET_SCV macro that treats any negative value
returned by syscall via scv ABI as an error, but this is not correct.
This bug was found by strace test suite.
Proposed fix was posted by Nicholas Piggin at
https://sourceware.org/pipermail/libc-alpha/2021-May/126534.html
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread* [Bug libc/27892] powerpc: scv ABI error handling fails to check IS_ERR_VALUE 2021-05-20 14:23 [Bug libc/27892] New: powerpc: scv ABI error handling fails to check IS_ERR_VALUE ldv at sourceware dot org @ 2021-05-20 21:28 ` tuliom at ascii dot art.br 2021-05-21 13:15 ` msc at linux dot ibm.com ` (2 subsequent siblings) 3 siblings, 0 replies; 5+ messages in thread From: tuliom at ascii dot art.br @ 2021-05-20 21:28 UTC (permalink / raw) To: glibc-bugs https://sourceware.org/bugzilla/show_bug.cgi?id=27892 Tulio Magno Quites Machado Filho <tuliom at ascii dot art.br> changed: What |Removed |Added ---------------------------------------------------------------------------- Target| |powerpc64* CC| |tuliom at ascii dot art.br -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug libc/27892] powerpc: scv ABI error handling fails to check IS_ERR_VALUE 2021-05-20 14:23 [Bug libc/27892] New: powerpc: scv ABI error handling fails to check IS_ERR_VALUE ldv at sourceware dot org 2021-05-20 21:28 ` [Bug libc/27892] " tuliom at ascii dot art.br @ 2021-05-21 13:15 ` msc at linux dot ibm.com 2021-05-24 20:26 ` msc at linux dot ibm.com 2021-05-24 20:26 ` msc at linux dot ibm.com 3 siblings, 0 replies; 5+ messages in thread From: msc at linux dot ibm.com @ 2021-05-21 13:15 UTC (permalink / raw) To: glibc-bugs https://sourceware.org/bugzilla/show_bug.cgi?id=27892 Matheus Castanho <msc at linux dot ibm.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |msc at linux dot ibm.com Assignee|unassigned at sourceware dot org |msc at linux dot ibm.com -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug libc/27892] powerpc: scv ABI error handling fails to check IS_ERR_VALUE 2021-05-20 14:23 [Bug libc/27892] New: powerpc: scv ABI error handling fails to check IS_ERR_VALUE ldv at sourceware dot org 2021-05-20 21:28 ` [Bug libc/27892] " tuliom at ascii dot art.br 2021-05-21 13:15 ` msc at linux dot ibm.com @ 2021-05-24 20:26 ` msc at linux dot ibm.com 2021-05-24 20:26 ` msc at linux dot ibm.com 3 siblings, 0 replies; 5+ messages in thread From: msc at linux dot ibm.com @ 2021-05-24 20:26 UTC (permalink / raw) To: glibc-bugs https://sourceware.org/bugzilla/show_bug.cgi?id=27892 Matheus Castanho <msc at linux dot ibm.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Matheus Castanho <msc at linux dot ibm.com> --- Issue fixed on master for glibc 2.34: commit 7de36744ee1325f35d3fe0ca079dd33c40b12267 Author: Nicholas Piggin <npiggin@gmail.com> Date: Thu May 20 11:00:36 2021 -0300 powerpc: Fix handling of scv return error codes [BZ #27892] When using scv for templated ASM syscalls, current code interprets any negative return value as error, but the only valid error codes are in the range -4095..-1 according to the ABI. This commit also fixes 'signal.gen.test' strace test, where the issue was first identified. Reviewed-by: Matheus Castanho <msc@linux.ibm.com> This patch was also backported to 2.33 by commit 0ef0e6de7fdfa18328b09ba2afb4f0112d4bdab4. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug libc/27892] powerpc: scv ABI error handling fails to check IS_ERR_VALUE 2021-05-20 14:23 [Bug libc/27892] New: powerpc: scv ABI error handling fails to check IS_ERR_VALUE ldv at sourceware dot org ` (2 preceding siblings ...) 2021-05-24 20:26 ` msc at linux dot ibm.com @ 2021-05-24 20:26 ` msc at linux dot ibm.com 3 siblings, 0 replies; 5+ messages in thread From: msc at linux dot ibm.com @ 2021-05-24 20:26 UTC (permalink / raw) To: glibc-bugs https://sourceware.org/bugzilla/show_bug.cgi?id=27892 Matheus Castanho <msc at linux dot ibm.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |2.34 -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-05-24 20:26 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-05-20 14:23 [Bug libc/27892] New: powerpc: scv ABI error handling fails to check IS_ERR_VALUE ldv at sourceware dot org 2021-05-20 21:28 ` [Bug libc/27892] " tuliom at ascii dot art.br 2021-05-21 13:15 ` msc at linux dot ibm.com 2021-05-24 20:26 ` msc at linux dot ibm.com 2021-05-24 20:26 ` msc at linux dot ibm.com
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).