public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "adhemerval.zanella at linaro dot org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/28350] ping receives SIGABRT on lib32-qemux86-64 caused by recvmsg()
Date: Mon, 27 Sep 2021 18:15:12 +0000	[thread overview]
Message-ID: <bug-28350-131-SuwUuwEWIs@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-28350-131@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=28350

Adhemerval Zanella <adhemerval.zanella at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adhemerval.zanella at linaro dot o
                   |                            |rg

--- Comment #2 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
(In reply to Florian Weimer from comment #1)
> We need to disable recvmsg time64 emulation for time32 calls, it causes too
> many issues.

I don't think we need to resort on this change, the issue is in fact that
__convert_scm_timestamps does not correctly update the last cmsg.  With the
following patch it fixes the regression:

diff --git a/sysdeps/unix/sysv/linux/convert_scm_timestamps.c
b/sysdeps/unix/sysv/linux/convert_scm_timestamps.c
index 00c934c413..4da2c60799 100644
--- a/sysdeps/unix/sysv/linux/convert_scm_timestamps.c
+++ b/sysdeps/unix/sysv/linux/convert_scm_timestamps.c
@@ -55,7 +55,10 @@ __convert_scm_timestamps (struct msghdr *msg, socklen_t
msgsize)
        cmsg = CMSG_NXTHDR (msg, cmsg))
     {
       if (cmsg->cmsg_level != SOL_SOCKET)
-       continue;
+       {
+         last = cmsg;
+         continue;
+       }

       switch (cmsg->cmsg_type)
        {

I will work on a patch along with a testcase.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-09-27 18:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-18  7:08 [Bug libc/28350] New: ping " yi.zhao at windriver dot com
2021-09-22  7:26 ` [Bug libc/28350] ping receives " yi.zhao at windriver dot com
2021-09-22 10:20 ` fweimer at redhat dot com
2021-09-22 13:02 ` sam at gentoo dot org
2021-09-22 13:02 ` sam at gentoo dot org
2021-09-27 18:15 ` adhemerval.zanella at linaro dot org [this message]
2021-12-22 18:39 ` adhemerval.zanella at linaro dot org
2022-01-12 13:30 ` cvs-commit at gcc dot gnu.org
2022-01-12 13:40 ` cvs-commit at gcc dot gnu.org
2022-01-28 21:21 ` adhemerval.zanella at linaro dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-28350-131-SuwUuwEWIs@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).