* [Bug network/28353] Race condition on __opensock
2021-09-19 12:45 [Bug network/28353] New: Race condition on __opensock adhemerval.zanella at linaro dot org
@ 2021-09-20 5:13 ` pgowda.cve at gmail dot com
2021-09-21 20:53 ` rwmacleod at gmail dot com
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: pgowda.cve at gmail dot com @ 2021-09-20 5:13 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=28353
pgowda <pgowda.cve at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pgowda.cve at gmail dot com
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug network/28353] Race condition on __opensock
2021-09-19 12:45 [Bug network/28353] New: Race condition on __opensock adhemerval.zanella at linaro dot org
2021-09-20 5:13 ` [Bug network/28353] " pgowda.cve at gmail dot com
@ 2021-09-21 20:53 ` rwmacleod at gmail dot com
2021-09-27 5:19 ` pgowda.cve at gmail dot com
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: rwmacleod at gmail dot com @ 2021-09-21 20:53 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=28353
Randy Macleod <rwmacleod at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rwmacleod at gmail dot com
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug network/28353] Race condition on __opensock
2021-09-19 12:45 [Bug network/28353] New: Race condition on __opensock adhemerval.zanella at linaro dot org
2021-09-20 5:13 ` [Bug network/28353] " pgowda.cve at gmail dot com
2021-09-21 20:53 ` rwmacleod at gmail dot com
@ 2021-09-27 5:19 ` pgowda.cve at gmail dot com
2021-09-27 14:37 ` fweimer at redhat dot com
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: pgowda.cve at gmail dot com @ 2021-09-27 5:19 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=28353
--- Comment #1 from pgowda <pgowda.cve at gmail dot com> ---
The following lines are present in socket.texi for
{unsigned int} if_nametoindex (const char *@var{ifname})
491 @c It opens a socket to use ioctl on the fd to get the index.
492 @c opensock may call socket and access multiple times until it finds a
493 @c socket family that works. The Linux implementation has a potential
494 @c concurrency issue WRT last_type and last_family not being updated
495 @c atomically, but it is harmless; the generic implementation, OTOH,
496 @c takes a lock, which makes all callers AS- and AC-Unsafe.
However, the explanation has been commented and not displayed in HTML file.
Had the information been present in HTML, it would be easier to debug and
synchronize multithreaded access on the caller side.
Can the above explanation be uncommented to get it reflected in HTML?
Thanks
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug network/28353] Race condition on __opensock
2021-09-19 12:45 [Bug network/28353] New: Race condition on __opensock adhemerval.zanella at linaro dot org
` (2 preceding siblings ...)
2021-09-27 5:19 ` pgowda.cve at gmail dot com
@ 2021-09-27 14:37 ` fweimer at redhat dot com
2021-09-28 17:50 ` fweimer at redhat dot com
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: fweimer at redhat dot com @ 2021-09-27 14:37 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=28353
Florian Weimer <fweimer at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at sourceware dot org |fweimer at redhat dot com
Status|NEW |ASSIGNED
CC| |fweimer at redhat dot com
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug network/28353] Race condition on __opensock
2021-09-19 12:45 [Bug network/28353] New: Race condition on __opensock adhemerval.zanella at linaro dot org
` (3 preceding siblings ...)
2021-09-27 14:37 ` fweimer at redhat dot com
@ 2021-09-28 17:50 ` fweimer at redhat dot com
2021-10-06 19:27 ` rwmacleod at gmail dot com
2022-02-03 19:30 ` fweimer at redhat dot com
6 siblings, 0 replies; 8+ messages in thread
From: fweimer at redhat dot com @ 2021-09-28 17:50 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=28353
Florian Weimer <fweimer at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
Target Milestone|--- |2.35
--- Comment #2 from Florian Weimer <fweimer at redhat dot com> ---
This commit removes the problematic code from glibc 2.35:
commit 5bf07e1b3a74232bfb8332275110be1a5da50f83
Author: Florian Weimer <fweimer@redhat.com>
Date: Tue Sep 28 18:55:49 2021 +0200
Linux: Simplify __opensock and fix race condition [BZ #28353]
AF_NETLINK support is not quite optional on modern Linux systems
anymore, so it is likely that the first attempt will always succeed.
Consequently, there is no need to cache the result. Keep AF_UNIX
and the Internet address families as a fallback, for the rare case
that AF_NETLINK is missing. The other address families previously
probed are totally obsolete be now, so remove them.
Use this simplified version as the generic implementation, disabling
Netlink support as needed.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug network/28353] Race condition on __opensock
2021-09-19 12:45 [Bug network/28353] New: Race condition on __opensock adhemerval.zanella at linaro dot org
` (4 preceding siblings ...)
2021-09-28 17:50 ` fweimer at redhat dot com
@ 2021-10-06 19:27 ` rwmacleod at gmail dot com
2022-02-03 19:30 ` fweimer at redhat dot com
6 siblings, 0 replies; 8+ messages in thread
From: rwmacleod at gmail dot com @ 2021-10-06 19:27 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=28353
--- Comment #3 from Randy Macleod <rwmacleod at gmail dot com> ---
@florian, do you think this should be back-ported to older releases such as
2.33, 2.34 ? It is a rare race but still a bug.
Also, should @pgowda send a patch to fix up the documentation:
$ rg "concurrency issue WRT last_type and last_family"
manual/socket.texi
494:@c concurrency issue WRT last_type and last_family not being updated
Thanks! ../Randy
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug network/28353] Race condition on __opensock
2021-09-19 12:45 [Bug network/28353] New: Race condition on __opensock adhemerval.zanella at linaro dot org
` (5 preceding siblings ...)
2021-10-06 19:27 ` rwmacleod at gmail dot com
@ 2022-02-03 19:30 ` fweimer at redhat dot com
6 siblings, 0 replies; 8+ messages in thread
From: fweimer at redhat dot com @ 2022-02-03 19:30 UTC (permalink / raw)
To: glibc-bugs
https://sourceware.org/bugzilla/show_bug.cgi?id=28353
--- Comment #4 from Florian Weimer <fweimer at redhat dot com> ---
Sorry, missed the ping. 2.33 and 2.34 backports are now done.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread