From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 9C0003858415; Tue, 5 Oct 2021 23:26:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9C0003858415 From: "gs-sourceware.org at gluelogic dot com" To: glibc-bugs@sourceware.org Subject: [Bug libc/28425] new __attribute_nonnull__(params) conflicts with third-party Date: Tue, 05 Oct 2021 23:26:44 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: libc X-Bugzilla-Version: 2.35 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: gs-sourceware.org at gluelogic dot com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: glibc-bugs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-bugs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Oct 2021 23:26:44 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D28425 --- Comment #1 from gstrauss --- In order to match glibc 2.35 development, I have modified lighttpd to define __attribute_nonnull__(params) with an argument for params, and I have modif= ied lighttpd usage from __attribute_nonnull__ to __attribute_nonnull__(). (Thi= s is also extensible to filling in params, e.g. __attribute_nonnull((1,2,3)), as= is recommended by gcc for passing a single arg or no arg to attributes.) lighttpd patch (not glibc): ``` #ifndef __attribute_nonnull__ #if __has_attribute(nonnull) \ || __GNUC_PREREQ(3,3) -#define __attribute_nonnull__ __attribute__((__nonnull__)) +#define __attribute_nonnull__(params) __attribute__((__nonnull__ params)) #else -#define __attribute_nonnull__ +#define __attribute_nonnull__(params) #endif #endif ``` (In hindsight, that is probably how I should have defined macros for attrib= utes which take an optional single argument as parenthesized set of 0 or more arguments.) --=20 You are receiving this mail because: You are on the CC list for the bug.=