public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "schwab@linux-m68k.org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/28531] New: [x86] Cancelable syscall stubs fail to preserve 16-byte stack alignment
Date: Wed, 03 Nov 2021 11:15:16 +0000	[thread overview]
Message-ID: <bug-28531-131@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=28531

            Bug ID: 28531
           Summary: [x86] Cancelable syscall stubs fail to preserve
                    16-byte stack alignment
           Product: glibc
           Version: 2.22
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: schwab@linux-m68k.org
                CC: drepper.fsp at gmail dot com, hjl.tools at gmail dot com
  Target Milestone: ---
              Host: i?86-*-linux*

On function entry, stack alignment is 4 mod 16, and there are function calls
without realigning the stack.

00000000 <__GI___nanosleep>:
   0:   65 83 3d 0c 00 00 00    cmpl   $0x0,%gs:0xc
   7:   00 
   8:   75 20                   jne    2a <__nanosleep_nocancel+0x20>

0000000a <__nanosleep_nocancel>:
   a:   89 da                   mov    %ebx,%edx
   c:   8b 4c 24 08             mov    0x8(%esp),%ecx
  10:   8b 5c 24 04             mov    0x4(%esp),%ebx
  14:   b8 a2 00 00 00          mov    $0xa2,%eax
  19:   65 ff 15 10 00 00 00    call   *%gs:0x10
  20:   89 d3                   mov    %edx,%ebx
  22:   3d 01 f0 ff ff          cmp    $0xfffff001,%eax
  27:   73 30                   jae    59 <__nanosleep_nocancel+0x4f>
  29:   c3                      ret    
  2a:   e8 fc ff ff ff          call   2b <__nanosleep_nocancel+0x21>
                        2b: R_386_PC32  __libc_enable_asynccancel

This is dormant on master, since there are no longer any cancelable syscalls
that are implemented using the stubs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2021-11-03 11:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 11:15 schwab@linux-m68k.org [this message]
2021-11-03 11:59 ` [Bug libc/28531] " rguenth at gcc dot gnu.org
2021-11-03 12:33 ` hjl.tools at gmail dot com
2021-11-03 13:03 ` schwab@linux-m68k.org
2021-11-03 13:06 ` hjl.tools at gmail dot com
2021-11-03 13:16 ` hjl.tools at gmail dot com
2021-11-03 13:56 ` schwab@linux-m68k.org
2021-11-03 14:19 ` adhemerval.zanella at linaro dot org
2021-11-03 14:35 ` schwab@linux-m68k.org
2021-11-03 14:40 ` schwab@linux-m68k.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-28531-131@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).