From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id B4A3D3858435; Fri, 17 Dec 2021 20:24:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B4A3D3858435 From: "msc at linux dot ibm.com" To: glibc-bugs@sourceware.org Subject: [Bug libc/28532] powerpc64[le]: CFI for assembly templated syscalls is incorrect Date: Fri, 17 Dec 2021 20:24:59 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: libc X-Bugzilla-Version: 2.35 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: msc at linux dot ibm.com X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: msc at linux dot ibm.com X-Bugzilla-Target-Milestone: 2.35 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: glibc-bugs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-bugs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2021 20:24:59 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D28532 Matheus Castanho changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED --- Comment #4 from Matheus Castanho --- New failing tests are now fixed by: commit ae91d3df24a4a1b1f264d101a71a298bff310d14 Author: Matheus Castanho Date: Wed Dec 1 11:14:40 2021 -0300 powerpc64[le]: Allocate extra stack frame on syscall.S The syscall function does not allocate the extra stack frame for scv li= ke other assembly syscalls using DO_CALL_SCV. So after commit d120fb9941 changed= the offset that is used to save LR, syscall ended up using an invalid offse= t, causing regressions on powerpc64. So make sure the extra stack frame is allocated in syscall.S as well to make it consistent with other uses of DO_CALL_SCV and avoid similar issues in the future. Tested on powerpc, powerpc64, and powerpc64le (with and without scv) Reviewed-by: Raphael M Zinsly --=20 You are receiving this mail because: You are on the CC list for the bug.=