From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 72C933857009; Thu, 11 Nov 2021 18:27:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 72C933857009 From: "goldstein.w.n at gmail dot com" To: glibc-bugs@sourceware.org Subject: [Bug libc/28572] Misaligned accesses in test-memcpy and test-mempcpy on hppa Date: Thu, 11 Nov 2021 18:27:33 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: libc X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: goldstein.w.n at gmail dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: glibc-bugs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-bugs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Nov 2021 18:27:33 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D28572 --- Comment #7 from Noah Goldstein --- (In reply to dave.anglin from comment #6) > On 2021-11-11 12:39 p.m., goldstein.w.n at gmail dot com wrote: > > commit d585ba47fcda99fdf228e3e45a01b11a15efbc5a > > Author: Noah Goldstein > > Date: Mon Nov 1 00:49:48 2021 -0500 > > > > string: Make tests birdirectional test-memcpy.c > > > > > > If its d585ba47fcda99fdf228e3e45a01b11a15efbc5a then the issue is simpl= y with > > the new tests. > It's the new tests that introduced the unaligned accesses.=C2=A0 That wor= ks okay > on x86 but not > on targets like PA-RISC that require strict alignment.=C2=A0 Even on x86,= I > believe unaligned accesses > are slower than aligned ones. >=20 > There's a unaligned handler in PA-RISC Linux kernel but it's slow. Is there a way to make the test arch specific? Generally would prefer keeping it in the `string/` directory so that its easier to run all the tests but the tests are a real issue for non-x86. I think we can move the large memcpy tests to sysdeps/x86_64 if=20 there is no way to do arch specific tests in `string/`. AFAIK x86_64 is the only implementation that has an extra-large case=20 that requires additional tests. H.J is there any reason that wouldn't work? > > > > I added them really just for x86_64 because the large memcpy case has s= ome > > complicated logic that was not previously tested. > > > > Possibly for the large memcpy tests we could only iterate through > > implementations returned by the ifunc and skip the generic/simple > > implementations to speed things up? > Test passes on hppa with change change attached to bug but takes about 13 > minutes. --=20 You are receiving this mail because: You are on the CC list for the bug.=