From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id A1A91385AC3D; Thu, 11 Nov 2021 20:05:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A1A91385AC3D From: "dave.anglin at bell dot net" To: glibc-bugs@sourceware.org Subject: [Bug libc/28572] Misaligned accesses in test-memcpy and test-mempcpy on hppa Date: Thu, 11 Nov 2021 20:05:54 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: libc X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: dave.anglin at bell dot net X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: glibc-bugs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-bugs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Nov 2021 20:05:54 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D28572 --- Comment #13 from dave.anglin at bell dot net --- On 2021-11-11 2:52 p.m., goldstein.w.n at gmail dot com wrote: > https://sourceware.org/bugzilla/show_bug.cgi?id=3D28572 > > --- Comment #9 from Noah Goldstein --- > (In reply to H.J. Lu from comment #8) >> memcpy should work on unaligned addresses. Also we need to increase >> TIMEOUT for memcpy. > It does "work" still. But if it takes 400+ minutes its not really a useful > test. That only happens when the unaligned accesses fault.=C2=A0 What's wrong wit= h marking the src and dst types as unaligned pointers (i.e., alignment of 1)? It's easy to modify the typedef in the patch to only use alignment 1 on hppa and other strict alignment architectures. > > I think these tests are important for x86 but if the burden on other targ= ets > is too high it doesn't seem reasonable to have them in `string/` I agree.=C2=A0 HJL already bumped timeout.=C2=A0 How much impact does patch= have on x86? commit a6a9c1a36b48f304c8a2138c147d88a448161366 Author: H.J. Lu Date:=C2=A0=C2=A0 Sun Nov 7 06:41:16 2021 -0800 =C2=A0=C2=A0=C2=A0 test-memcpy.c: Double TIMEOUT to (8 * 60) =C2=A0=C2=A0=C2=A0 commit d585ba47fcda99fdf228e3e45a01b11a15efbc5a =C2=A0=C2=A0=C2=A0 Author: Noah Goldstein =C2=A0=C2=A0=C2=A0 Date:=C2=A0=C2=A0 Mon Nov 1 00:49:48 2021 -0500 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 string: Make tests birdirection= al test-memcpy.c =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 This commit updates the memcpy = tests to test both dst > src and dst < =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 src. This is because there is l= ogic in the code based on the =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Signed-off-by: Noah Goldstein <= goldstein.w.n@gmail.com> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Reviewed-by: H.J. Lu =C2=A0=C2=A0=C2=A0 significantly increased the number of tests.=C2=A0 On I= ntel Core i7-1165G7, =C2=A0=C2=A0=C2=A0 test-memcpy takes 120 seconds to run when machine is id= le. Double =C2=A0=C2=A0=C2=A0 TIMEOUT to (8 * 60) for test-memcpy to avoid timeout wh= en machine is =C2=A0=C2=A0=C2=A0 under heavy load. Dave --=20 You are receiving this mail because: You are on the CC list for the bug.=