public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sourceware.org Subject: [Bug libc/28784] x86: crash in 32bit memset-sse2.s when the cache size can not be determined Date: Tue, 18 Jan 2022 06:45:07 +0000 [thread overview] Message-ID: <bug-28784-131-RKlYvAjjxx@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-28784-131@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=28784 --- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> --- The release/2.33/master branch has been updated by Aurelien Jarno <aurel32@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a51b76b71e8190a50b0e0c0b32f313888b930108 commit a51b76b71e8190a50b0e0c0b32f313888b930108 Author: Aurelien Jarno <aurelien@aurel32.net> Date: Mon Jan 17 19:41:40 2022 +0100 x86: use default cache size if it cannot be determined [BZ #28784] In some cases (e.g QEMU, non-Intel/AMD CPU) the cache information can not be retrieved and the corresponding values are set to 0. Commit 2d651eb9265d ("x86: Move x86 processor cache info to cpu_features") changed the behaviour in such case by defining the __x86_shared_cache_size and __x86_data_cache_size variables to 0 instead of using the default values. This cause an issue with the i686 SSE2 optimized bzero/routine which assumes that the cache size is at least 128 bytes, and otherwise tries to zero/set the whole address space minus 128 bytes. Fix that by restoring the original code to only update __x86_shared_cache_size and __x86_data_cache_size variables if the corresponding cache sizes are not zero. Fixes bug 28784 Fixes commit 2d651eb9265d Reviewed-by: H.J. Lu <hjl.tools@gmail.com> (cherry picked from commit c242fcce06e3102ca663b2f992611d0bda4f2668) -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2022-01-18 6:45 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-15 10:12 [Bug libc/28784] New: [x86] " aurelien at aurel32 dot net 2022-01-15 10:17 ` [Bug libc/28784] " aurelien at aurel32 dot net 2022-01-17 18:43 ` cvs-commit at gcc dot gnu.org 2022-01-17 18:44 ` aurelien at aurel32 dot net 2022-01-17 18:45 ` [Bug libc/28784] x86: " aurelien at aurel32 dot net 2022-01-17 18:47 ` cvs-commit at gcc dot gnu.org 2022-01-18 6:45 ` cvs-commit at gcc dot gnu.org [this message] 2023-01-24 20:33 ` decui at microsoft dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-28784-131-RKlYvAjjxx@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).