[Bug libc/28880] Program crashes if date beyone 2038

["adhemerval.zanella at linaro dot org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=28880

Adhemerval Zanella <adhemerval.zanella at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.36
           Assignee|unassigned at sourceware dot org   |adhemerval.zanella at linaro dot o
                   |                            |rg
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2022-02-11
                 CC|                            |adhemerval.zanella at linaro dot o
                   |                            |rg

--- Comment #1 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---

(In reply to Vignesh from comment #0)
> Hi,
> 
> I am trying to set a date (beyond 2038) and use the following example
> program.
> 
> https://stackoverflow.com/questions/70491311/after-update-glibc-to-version-2-
> 34-sem-open-failed-sem-open-fail-read-only
> If I set the date below 2038 the program executes well, and if I set 2039 it
> throws the below error
> 
> WORKS:
> root@(none):/home$ date -s "5 MAR 2037 18:00:00"                            
> 
> Thu Mar  5 18:00:00  2037
> root@(none):/home$ ./sem abc
> 
> FAILS:
> root@(none):/home$ date
> Sat Mar  5 18:00:12  2039
> root@(none):/home$ ./sem foo
> sem_open fail: Value too large for defined data type
> 
> All the userspace applications and the example program were compiled with
> these tokens
> -D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64

It is a missing spot from my fix 52a5fe70a2c to use 64 bit stat internally, the
following makes the programs pass:

diff --git a/sysdeps/pthread/sem_routines.c b/sysdeps/pthread/sem_routines.c
index 9e1924398d..877e1e8556 100644
--- a/sysdeps/pthread/sem_routines.c
+++ b/sysdeps/pthread/sem_routines.c
@@ -25,7 +25,7 @@
 struct inuse_sem
 {
   dev_t dev;
-  ino_t ino;
+  ino64_t ino;
   int refcnt;
   sem_t *sem;
   char name[];
@@ -34,7 +34,7 @@ struct inuse_sem
 struct search_sem
 {
   dev_t dev;
-  ino_t ino;
+  ino64_t ino;
   int refcnt;
   sem_t *sem;
   char name[NAME_MAX + 1];
@@ -77,8 +77,8 @@ __sem_check_add_mapping (const char *name, int fd, sem_t
*existing)
   sem_t *result = SEM_FAILED;

   /* Get the information about the file.  */
-  struct stat64 st;
-  if (__fstat64 (fd, &st) == 0)
+  struct __stat64_t64 st;
+  if (__fstat64_time64 (fd, &st) == 0)
     {
       /* Get the lock.  */
       lll_lock (sem_mappings_lock, LLL_PRIVATE);

> 
> But the glibc 2.34 wasn't compiled with those.
> 
> My understanding is that glibc also sholud be compiled with -D_TIME_BITS=64
> -D_FILE_OFFSET_BITS=64

No, these flags should be used only the programs to select the time_t and LFS
support. glibc from 2.34 always provide both 32-bit and 64-bit time_t ABI,
there is no need to enable it either through configure or extra cflags.

-- 
You are receiving this mail because:
You are on the CC list for the bug.