public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ats-sourceware at offog dot org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug string/29127] New: Incomplete backport causes tst-{strncmp,wcsncmp}-rtm to fail
Date: Sat, 07 May 2022 01:17:36 +0000 [thread overview]
Message-ID: <bug-29127-131@http.sourceware.org/bugzilla/> (raw)
https://sourceware.org/bugzilla/show_bug.cgi?id=29127
Bug ID: 29127
Summary: Incomplete backport causes tst-{strncmp,wcsncmp}-rtm
to fail
Product: glibc
Version: 2.35
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: string
Assignee: unassigned at sourceware dot org
Reporter: ats-sourceware at offog dot org
Target Milestone: ---
Created attachment 14093
--> https://sourceware.org/bugzilla/attachment.cgi?id=14093&action=edit
Sample fix for 2.35 branch
The commit c6272098323153db373f2986c67786ea8c85f1cf ("x86: Fallback
{str|wcs}cmp RTM in the ncmp overflow case [BZ #28896]") was backported as
fd412fff6d2bd322ec24ebd13fab196efc6c5506 to the 2.35 branch, but the backported
version doesn't cover all of the fallback cases in the original commit.
(Looking at #28896, maybe the original version got backported rather than the
revised version that went into master?)
On my i7-9700KF, this causes string/tst-strncmp-rtm and string/tst-wcsncmp-rtm
to fail with:
error: ../sysdeps/x86/tst-string-rtm.h:63: TSX abort rate: 100.00% (3000 out of
3000)
I've attached an example patch to fix this for 2.35 - just making the
appropriate bit of sysdeps/x86_64/multiarch/strcmp-avx2.S match what's now in
master - but a similar fix probably needs applying to the other release
branches too.
--
You are receiving this mail because:
You are on the CC list for the bug.
next reply other threads:[~2022-05-07 1:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-07 1:17 ats-sourceware at offog dot org [this message]
2022-05-23 13:32 ` [Bug string/29127] " fweimer at redhat dot com
2022-05-23 15:25 ` goldstein.w.n at gmail dot com
2022-05-25 22:03 ` cvs-commit at gcc dot gnu.org
2022-05-25 23:08 ` cvs-commit at gcc dot gnu.org
2022-05-25 23:11 ` cvs-commit at gcc dot gnu.org
2022-05-25 23:24 ` ats-sourceware at offog dot org
2022-05-26 3:01 ` hjl.tools at gmail dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-29127-131@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=glibc-bugs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).