From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 1493A3856DC4; Fri, 20 May 2022 14:59:25 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1493A3856DC4
From: "slyich at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug string/29162] New: [PATCH] string.h syntactic error:
 include/bits/string_fortified.h:110: error: expected ',' or ';' before
 '__fortified_attr_access'
Date: Fri, 20 May 2022 14:59:24 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: glibc
X-Bugzilla-Component: string
X-Bugzilla-Version: 2.35
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: slyich at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter cc target_milestone
 attachments.created
Message-ID: <bug-29162-131@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: glibc-bugs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Glibc-bugs mailing list <glibc-bugs.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/glibc-bugs>,
 <mailto:glibc-bugs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/glibc-bugs/>
List-Help: <mailto:glibc-bugs-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/glibc-bugs>,
 <mailto:glibc-bugs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 20 May 2022 14:59:25 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D29162

            Bug ID: 29162
           Summary: [PATCH] string.h syntactic error:
                    include/bits/string_fortified.h:110: error: expected
                    ',' or ';' before '__fortified_attr_access'
           Product: glibc
           Version: 2.35
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: string
          Assignee: unassigned at sourceware dot org
          Reporter: slyich at gmail dot com
                CC: siddhesh at sourceware dot org
  Target Milestone: ---

Created attachment 14109
  --> https://sourceware.org/bugzilla/attachment.cgi?id=3D14109&action=3Ded=
it
0001-string.h-fix-__fortified_attr_access-macro-call.patch

Initially noticed as a gnat-6 build failure:
https://hydra.nixos.org/log/1rya10nw23lm6im8frkk5z3ic9ibb80m-gnat-6.5.0.drv

/nix/store/hd3j5xfvffs4vaa74l1har94q10fpnm5-glibc-2.34-210-dev/include/bits=
/string_fortified.h:110:50:
error: macro "__fortified_attr_access" requires 3 arguments, but only 1 giv=
en

I think it's a recent glibc regression from commit
e938c02748402c50f60ba0eb983273e7b52937d1 "Don't add access size hints to
fortifiable functions".

I'm testing locally the following fix:

--- a/string/bits/string_fortified.h
+++ b/string/bits/string_fortified.h
@@ -107,7 +107,7 @@ __NTH (stpncpy (char *__dest, const char *__src, size_t
__n))
 # else
 extern char *__stpncpy_chk (char *__dest, const char *__src, size_t __n,
                            size_t __destlen) __THROW
-  __fortified_attr_access ((__write_only__, 1, 3))
+  __fortified_attr_access (__write_only__, 1, 3)
   __attr_access ((__read_only__, 2));
 extern char *__REDIRECT_NTH (__stpncpy_alias, (char *__dest, const char
*__src,
                                               size_t __n), stpncpy);

--=20
You are receiving this mail because:
You are on the CC list for the bug.=