From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 1194338418B7; Tue, 21 Jun 2022 04:45:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1194338418B7 From: "siddhesh at sourceware dot org" To: glibc-bugs@sourceware.org Subject: [Bug string/29265] mbstowcs with NULL dst throws an incorrect warning (glibc == 2.35, gcc=12.0.1) Date: Tue, 21 Jun 2022 04:45:10 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: string X-Bugzilla-Version: 2.35 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: siddhesh at sourceware dot org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: glibc-bugs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-bugs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2022 04:45:11 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D29265 --- Comment #6 from Siddhesh Poyarekar --- (In reply to Noah Goldstein from comment #5) > (In reply to Siddhesh Poyarekar from comment #4) > > I'm not very picky about having a test for this FWIW, this seems very > > sensitive to optimizations and may not survive gcc updates. > >=20 > > As for the fix, just remove the __attr_access ((__write_only__, 1, 3)), > > it's incorrect in the context of mbstowcs definition. >=20 > You don't think its worth preserving if dst is non-null? In that case it = is > meaningful no? It is meaningful, just that the check may trigger if the dest pointer has n= ot yet been simplified to a const. Although, maybe I'm overthinking it. Lets= go with what you have. --=20 You are receiving this mail because: You are on the CC list for the bug.=