public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "goldstein.w.n at gmail dot com" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sourceware.org Subject: [Bug libc/29313] MIN/MAX macros can cause double evaluation of arguments Date: Fri, 01 Jul 2022 17:00:14 +0000 [thread overview] Message-ID: <bug-29313-131-dfo2pkKQTo@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-29313-131@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=29313 Noah Goldstein <goldstein.w.n at gmail dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |goldstein.w.n at gmail dot com --- Comment #3 from Noah Goldstein <goldstein.w.n at gmail dot com> --- (In reply to Vasilis Gkoumplias from comment #0) > * MIN, MAX macros as defined in misc/sys/param.h > https://sourceware.org/git/?p=glibc.git;a=blob_plain;f=misc/sys/param.h; > hb=HEAD > can cause the double evaluation of one of the passed in arguments. > Currently MAX is defined as: > #define MAX(a,b) (((a)>(b))?(a):(b)) > This will evaluate the maximum argument twice. > > * A test case to reproduce this would go like this: > int a = 1000; > int b = 10; > MAX(a++, b++) ; > // This will fail as a will be 1002 due to double evaluation by the MAX macro > EXPECT_EQ(a, 1001) > > * solution > #define max(a,b) \ > ({ __typeof__ (a) _a = (a); \ > __typeof__ (b) _b = (b); \ > _a > _b ? _a : _b; }) > > * A discussion (and a solution) for the matter can be found here > https://stackoverflow.com/questions/3437404/min-and-max-in-c > I don't think we can change the existing macros to that because they will no longer be usable outside of functions. #define MAX(x, y) ((x) > (y) ? (x) : (y)) #define max(a, b) \ ({ \ __typeof__(a) _a = (a); \ __typeof__(b) _b = (b); \ _a > _b ? _a : _b; \ }) enum { A = 1, B = 2 }; // Okay enum { C = MAX(A, B) }; // Compile error enum { D = max(A, B) }; > > Thanks -- You are receiving this mail because: You are on the CC list for the bug.
prev parent reply other threads:[~2022-07-01 17:00 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-01 11:13 [Bug libc/29313] New: " gkoumplias at gmail dot com 2022-07-01 12:21 ` [Bug libc/29313] " schwab@linux-m68k.org 2022-07-01 12:32 ` adhemerval.zanella at linaro dot org 2022-07-01 17:00 ` goldstein.w.n at gmail dot com [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-29313-131-dfo2pkKQTo@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).