public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "zackw at panix dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/29399] Wrong definition of setjmp
Date: Thu, 28 Jul 2022 19:38:58 +0000	[thread overview]
Message-ID: <bug-29399-131-2y2kwMdJTI@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29399-131@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29399

Zack Weinberg <zackw at panix dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zackw at panix dot com

--- Comment #6 from Zack Weinberg <zackw at panix dot com> ---
I don't think the standard is ambiguous at all.  Its wording could be improved,
but there's only one interpretation that makes sense.

Since at least C11, section 7.1.3p2 reads in part

> If the program declares or defines an identifier in a context in which it is reserved (other than as allowed by 7.1.4), **or defines a reserved identifier as a macro name**, the behavior is undefined.

The clause set off by double asterisks doesn't make any sense unless "a
reserved identifier" is understood broadly: if the program defines an
identifier that is reserved *in any context* as macro name, the behavior is
undefined.

To put it another way, I believe the intent of this sentence is that any
identifier that is reserved in any phase-7 context is also, unconditionally,
reserved for use as a macro name.

---

The program in comment 4 defines a reserved identifier as a macro name, and is
therefore invalid.  The program in comment 0, on the other hand, doesn't define
any macros; it defines a *local variable*, using a name that is reserved for
use by the implementation *only* at file scope.  This clashes with setjmp.h
assuming that the `_setjmp` in the expansion of the `setjmp` macro will refer
to a global symbol.  I think this *is* a bug in glibc's setjmp.h.  The thing
it's doing with macros should be done with __REDIRECT instead.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2022-07-28 19:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-24 19:25 [Bug libc/29399] New: " pavel.morozkin at gmail dot com
2022-07-24 21:28 ` [Bug libc/29399] " sam at gentoo dot org
2022-07-24 21:34 ` ldv at sourceware dot org
2022-07-24 22:06 ` pavel.morozkin at gmail dot com
2022-07-24 22:09 ` schwab@linux-m68k.org
2022-07-28 16:33 ` pavel.morozkin at gmail dot com
2022-07-28 16:50 ` fweimer at redhat dot com
2022-07-28 19:38 ` zackw at panix dot com [this message]
2022-07-29  6:53 ` pavel.morozkin at gmail dot com
2022-07-29 12:25 ` fweimer at redhat dot com
2022-07-29 14:03 ` pavel.morozkin at gmail dot com
2022-07-29 15:53 ` schwab@linux-m68k.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29399-131-2y2kwMdJTI@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).