From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 21F0F385801E; Mon, 8 Aug 2022 02:52:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 21F0F385801E From: "goldstein.w.n at gmail dot com" To: glibc-bugs@sourceware.org Subject: [Bug build/29454] dl-cache.c:513: undefined reference to `strcpy' with -Og or -O1 (doesn't happen with -O2) Date: Mon, 08 Aug 2022 02:52:17 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: build X-Bugzilla-Version: 2.36 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: goldstein.w.n at gmail dot com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: glibc-bugs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-bugs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Aug 2022 02:52:18 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D29454 --- Comment #17 from Noah Goldstein --- (In reply to H.J. Lu from comment #16) > (In reply to Noah Goldstein from comment #12) >=20 > > which I think is a different issue. > >=20 > > H.J I will post this patch (and the other one for the ifdef tomorrow > > morning). Do you know why this was necessary for the non-optimized buil= d? >=20 > Some parts of glibc must be compiled with optimization. If there is foo.= [cS] > under sysdeps/x86_64/multiarch, the one in sysdeps/x86_64 will be ignored. > Does GCC inline strcpy with -O2 in dl-cache.c? Yeah the usage is: ``` char *temp; temp =3D alloca (strlen (best) + 1); strcpy (temp, best); return __strdup (temp); ``` Which gets converted to `memcpy` (because of already computed strlen) in strlen_pass::handle_builtin_strcpy. --=20 You are receiving this mail because: You are on the CC list for the bug.=