public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "adhemerval.zanella at linaro dot org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug build/29456] missing DT_HASH section in shared objects
Date: Mon, 08 Aug 2022 14:49:57 +0000	[thread overview]
Message-ID: <bug-29456-131-EqwRcTfNXB@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29456-131@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29456

--- Comment #7 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
(In reply to Arkadiusz Hiler from comment #5)
> (In reply to Florian Weimer from comment #3)
> > Distributions configure or patch GCC to pass --hash-style=gnu to the linker
> > by default. The linker default does not matter.
> 
> Thanks, that explains a few things. My gcc -v indeed claims that:
> 
>     Configured with: /build/gcc/src/gcc/configure ...
> --with-linker-hash-style=gnu ...
> 
> According to gcc/docs/install.texi the default is sysv but after browsing
> the code for a bit it looks like if `--with-linker-hash-style` is not
> specified no `--hash-style` is passed to the linker so it would depend on
> linker's defaults.
> 
> Do you know why distros do this? Looking at package history it seems like an
> artifact from the times where both was a bit problematic. There used to be
> some custom patches for that years ago.
> 
> 
> (In reply to Adhemerval Zanella from comment #4)
> > > This breaks all the games running via Proton that are using EAC.
> > 
> > What EAC is doing exactly that requires a DT_HASH on glibc? What happens if
> > you mix DT_HASH and DT_GNU_HASH shared objects (for instance shared
> > libraries with only one option)? It does seem a shortcoming from EAC,
> > although I am not sure what exactly it is trying to enforce here.
> 
> I can only guess but probably to look up some symbols in multiple ways to
> assure no hooking has occurred.
> 
> It seems to require it only for the glibc DSOs as they were shipping with
> DT_HASH for years, even on distros that default to gnu, and this is an
> unexpected change.

Right, however, I am not sure this characterize as an ABI break since the
symbol lookup information would be indeed provided (albeit in a different
format). And it should be transparent to most applications as well since symbol
resolution is done by the loader itself.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2022-08-08 14:49 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08  9:10 [Bug build/29456] New: " arek at hiler dot eu
2022-08-08  9:39 ` [Bug build/29456] " mikhail.v.gavrilov at gmail dot com
2022-08-08 10:45 ` fweimer at redhat dot com
2022-08-08 11:33 ` arek at hiler dot eu
2022-08-08 12:01 ` fweimer at redhat dot com
2022-08-08 12:43 ` adhemerval.zanella at linaro dot org
2022-08-08 14:34 ` arek at hiler dot eu
2022-08-08 14:45 ` fweimer at redhat dot com
2022-08-08 14:49 ` adhemerval.zanella at linaro dot org [this message]
2022-08-08 15:08 ` arek at hiler dot eu
2022-08-08 15:29 ` adhemerval.zanella at linaro dot org
2022-08-08 16:49 ` arek at hiler dot eu
2022-08-08 17:13 ` adhemerval.zanella at linaro dot org
2022-08-08 17:32 ` adhemerval.zanella at linaro dot org
2022-08-08 19:58 ` sam at gentoo dot org
2022-08-08 19:58 ` sam at gentoo dot org
2022-08-09 16:12 ` freswa at archlinux dot org
2022-08-12  7:46 ` arek at hiler dot eu
2022-08-12 13:17 ` adhemerval.zanella at linaro dot org
2022-08-14 21:33 ` hi-angel at yandex dot ru
2022-08-24  4:12 ` i at maskray dot me
2022-08-24  8:28 ` rguenth at gcc dot gnu.org
2022-08-24  8:56 ` fweimer at redhat dot com
2022-08-24  8:57 ` mliska at suse dot cz
2023-08-11 15:40 ` es20490446e at gmail dot com
2023-08-11 15:58 ` carlos at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29456-131-EqwRcTfNXB@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).