From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id B659D385C41C; Tue, 30 Aug 2022 13:18:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B659D385C41C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1661865490; bh=tdiy7O49/O1Baa9Y24bAYAZJT0ENSeSqQXT4qdHviZY=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Bba3qZAOXAhxCKZUPMmtpOeAmI0O8Tp2lf/MpVfpycjI9WfNnYybGWRt5JcLmPeA0 qWG0BRbNCycp1mked2ydDLzuaCpPyJR2PgOueVee1vxR5RtMfnmWP5OLSzb3zOy5CU FuWpAzgH94PtIZ37z6mCmIwE8ee6UWSGIx0LIN64= From: "adhemerval.zanella at linaro dot org" To: glibc-bugs@sourceware.org Subject: [Bug libc/29537] [2.34 regression]: Alignment issue on m68k when using futexes on qemu-user Date: Tue, 30 Aug 2022 13:18:10 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: libc X-Bugzilla-Version: 2.34 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: adhemerval.zanella at linaro dot org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D29537 --- Comment #2 from Adhemerval Zanella --- It seems a real issue, but I am puzzled why we have not see any issue so fa= r. I take mostly runs were done in single-core, where hardware did not enforce 32-bit alignment with atomic operations. A better change would be to use: diff --git a/sysdeps/nptl/libc-lockP.h b/sysdeps/nptl/libc-lockP.h index d3a6837fd2..9efe962588 100644 --- a/sysdeps/nptl/libc-lockP.h +++ b/sysdeps/nptl/libc-lockP.h @@ -34,7 +34,7 @@ #include /* Mutex type. */ -typedef int __libc_lock_t; +typedef int __libc_lock_t __LOCK_ALIGNMENT; typedef struct { pthread_mutex_t mutex; } __rtld_lock_recursive_t; typedef pthread_rwlock_t __libc_rwlock_t; Since __LOCK_ALIGNMENT is defined per architecture if required. The HPPA a= lso requires a 16-byte alignment for locks, although it is just a historical artifact to keep compatibility with old implementation. --=20 You are receiving this mail because: You are on the CC list for the bug.=