From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 427A93858C53; Tue, 13 Sep 2022 17:59:48 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 427A93858C53
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1663091988;
	bh=c1Nez8X6gl0KjKRmAeaECFKBFrLqoCtUoaJMhhfAP4Q=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=c/f3fYWZDTu262lKyvEKBvGS+igtK2M5EvM/Z5jkDytv51kZKvWebeqDvMr8fXdGa
	 NmIldbpLbKUb92Rpv6jbK7HuFhJhapxcOFW8LIHmKPo60mbzu6fB51kdQ03kriDSPZ
	 y90m/R24iuP5zQRcRYI/pOyMknYrzfnsh3jPnFGs=
From: "siddhesh at sourceware dot org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug build/29564] Incorrect way to change MAKEFLAGS in Makerules
Date: Tue, 13 Sep 2022 17:59:48 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: glibc
X-Bugzilla-Component: build
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: siddhesh at sourceware dot org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: 2.37
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: target_milestone resolution bug_status
Message-ID: <bug-29564-131-78Y9Xg3sft@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-29564-131@http.sourceware.org/bugzilla/>
References: <bug-29564-131@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <glibc-bugs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D29564

Siddhesh Poyarekar <siddhesh at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.37
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Siddhesh Poyarekar <siddhesh at sourceware dot org> ---
Fixed.

https://sourceware.org/git/?p=3Dglibc.git;a=3Dcommit;h=3D2d7ed98add14f75041=
499ac189696c9bd3d757fe

author  Sergei Trofimovich <slyich@gmail.com>=20=20=20
        Tue, 13 Sep 2022 17:39:13 +0000 (13:39 -0400)
committer       Siddhesh Poyarekar <siddhesh@sourceware.org>=20=20=20=20
        Tue, 13 Sep 2022 17:45:32 +0000 (13:45 -0400)
commit  2d7ed98add14f75041499ac189696c9bd3d757fe
tree    2f9d6695d288f31666f7aaad5c52add48b8a6470        tree
parent  a30e960328fc60e066967d1224ecd5b6e173cda3        commit | diff
Makerules: fix MAKEFLAGS assignment for upcoming make-4.4 [BZ# 29564]

make-4.4 will add long flags to MAKEFLAGS variable:

    * WARNING: Backward-incompatibility!
      Previously only simple (one-letter) options were added to the MAKEFLA=
GS
      variable that was visible while parsing makefiles.  Now, all options
      are available in MAKEFLAGS.

This causes locale builds to fail when long options are used:

    $ make --shuffle
    ...
    make  -C localedata install-locales
    make: invalid shuffle mode: '1662724426r'

The change fixes it by passing eash option via whitespace and dashes.
That way option is appended to both single-word form and whitespace
separated form.

While at it fixed --silent mode detection in $(MAKEFLAGS) by filtering
out --long-options. Otherwise options like --shuffle flag enable silent
mode unintentionally. $(silent-make) variable consolidates the checks.

Resolves: BZ# 29564

CC: Paul Smith <psmith@gnu.org>
CC: Siddhesh Poyarekar <siddhesh@gotplt.org>
Signed-off-by: Sergei Trofimovich <slyich@gmail.com>
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>

--=20
You are receiving this mail because:
You are on the CC list for the bug.=