From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 0C9A3385828D; Sun, 11 Sep 2022 17:18:30 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0C9A3385828D
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1662916711;
	bh=Wd9jDTmxUeT3+oTdy+/ZDrkJuUEkfhzvEZ8eQlCDP7I=;
	h=From:To:Subject:Date:From;
	b=qB5bd/sKpcUJnVh5Jthb4FPap1Gy9NtWUvCHmvGNToMFHcwSbUr3I+CC1S/l+aR1R
	 ddSr11FpyomReaoPoT4aVyseDa++aNJ4bnBKHrv5Xf77RX6/9R/Uv9t9BI3YKFhGC/
	 WHIjPiJq6IS4af8mC3V2W/wbuU422YewLsb8JRss=
From: "psmith at gnu dot org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug build/29564] New: Incorrect way to change MAKEFLAGS in
 Makerules
Date: Sun, 11 Sep 2022 17:18:30 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: glibc
X-Bugzilla-Component: build
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: psmith at gnu dot org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter cc target_milestone
Message-ID: <bug-29564-131@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <glibc-bugs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D29564

            Bug ID: 29564
           Summary: Incorrect way to change MAKEFLAGS in Makerules
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: psmith at gnu dot org
                CC: carlos at redhat dot com
  Target Milestone: ---

The glibc Makerules file contains this:

  # Don't define any builtin rules.
  MAKEFLAGS :=3D $(MAKEFLAGS)r

This is not a valid way to modify the MAKEFLAGS variable.  GNU make always
ensures that all options which have single-letter forms are used as the fir=
st
argument, however there are options to GNU make which do NOT have single-le=
tter
forms and those are added after the single-letter forms in MAKEFLAGS.

If you use the above structure, the "r" is just appended to the end of what=
ever
the last option happens to be, which will result in an error if the person
invoking make provided a long option without a single-letter form.

This should be:

  MAKEFLAGS :=3D $(MAKEFLAGS) -r

or probably even better:

  MAKEFLAGS +=3D -r

--=20
You are receiving this mail because:
You are on the CC list for the bug.=