[Bug libc/29578] New: Definition of SUN_LEN() is wrong

[Bug libc/29578] New: Definition of SUN_LEN() is wrong

[bart.vanassche at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29578

            Bug ID: 29578
           Summary: Definition of SUN_LEN() is wrong
           Product: glibc
           Version: 2.38
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: bart.vanassche at gmail dot com
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

$ PAGER= git grep -A1 'define SUN_LEN'
socket/sys/un.h:# define SUN_LEN(ptr) ((size_t) (((struct sockaddr_un *)
0)->sun_path)        \
socket/sys/un.h-                      + strlen ((ptr)->sun_path))

An ampersand (&) is missing after (size_t).

The commit that introduced this incorrect definition is d38cd08ca397 ("update
from main archive 961229").

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/29578] Definition of SUN_LEN() is wrong

[schwab@linux-m68k.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29578

Andreas Schwab <schwab@linux-m68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |NOTABUG
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #1 from Andreas Schwab <schwab@linux-m68k.org> ---
sun_path is an array and implicitly promotes to a pointer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/29578] Definition of SUN_LEN() is wrong

[bart.vanassche at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29578

--- Comment #2 from Bart Van Assche <bart.vanassche at gmail dot com> ---
I created this report because UndefinedBehaviorSanitizer reports the following
when using the SUN_LEN() macro:

runtime error: member access within null pointer of type 'struct sockaddr_un'

The above message may indicate a bug in the UndefinedBehaviorSanitizer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/29578] Definition of SUN_LEN() is wrong

[schwab@linux-m68k.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29578

Andreas Schwab <schwab@linux-m68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|NOTABUG                     |---
   Last reconfirmed|                            |2022-09-18
     Ever confirmed|0                           |1

--- Comment #3 from Andreas Schwab <schwab@linux-m68k.org> ---
That should have been part of the original description.  This is about the
offsetof operation, not adress-of.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/29578] Definition of SUN_LEN() is wrong

[schwab@linux-m68k.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29578

Andreas Schwab <schwab@linux-m68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
            Version|2.38                        |unspecified
   Target Milestone|---                         |2.37
         Resolution|---                         |FIXED

--- Comment #4 from Andreas Schwab <schwab@linux-m68k.org> ---
Fixed in 2.37.

-- 
You are receiving this mail because:
You are on the CC list for the bug.