From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 24D263858439; Sat,  1 Oct 2022 15:23:46 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 24D263858439
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1664637826;
	bh=GTIjmlRGpsrREh3tDmQSv9N1S5xV/HM/1YIAqmeA3U8=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=tpmyLFl1SEUp2CCEx08JY9PpoBCNlL+H8sabe39MEot0ymtNe/bXQCa8N7cKEr7nM
	 EbTIBzyDutLB8kJ43JhC2IpRalikkehmIHOhPbfp7Q1gCC1V9kP46mUlKUQWrmCRYC
	 5NxCpruWSLAuO/P9Ozb3EsfTDktm5jCaH6XiqZUs=
From: "aurelien at aurel32 dot net" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug string/29611] Optimized AVX2 string functions unconditionally
 use BMI2 instructions
Date: Sat, 01 Oct 2022 15:23:45 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: glibc
X-Bugzilla-Component: string
X-Bugzilla-Version: 2.31
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: critical
X-Bugzilla-Who: aurelien at aurel32 dot net
X-Bugzilla-Status: REOPENED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: goldstein.w.n at gmail dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-29611-131-5NicLoAsVy@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-29611-131@http.sourceware.org/bugzilla/>
References: <bug-29611-131@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <glibc-bugs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D29611

Aurelien Jarno <aurelien at aurel32 dot net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #28 from Aurelien Jarno <aurelien at aurel32 dot net> ---
(In reply to Noah Goldstein from comment #12)
> (In reply to Aurelien Jarno from comment #11)
> > Before trying to fix that in older branches, we should start by fixing
> > master. 3 groups of functions are using BMI2: memchr, strchr and strlen.
> > * strchr is fixed by this commit:
> >=20
> > commit 83c5b368226c34a2f0a5287df40fc290b2b34359
> > Author: H.J. Lu <hjl.tools@gmail.com>
> > Date:   Mon Apr 19 10:45:07 2021 -0700
> >=20
> >     x86-64: Require BMI2 for strchr-avx2.S
> >=20
> > * strlen is fixed by this commit:
> >=20
> > commit aaa23c35071537e2dcf5807e956802ed215210aa
> > Author: Noah Goldstein <goldstein.w.n@gmail.com>
> > Date:   Mon Apr 19 19:36:07 2021 -0400
> >=20
> >     x86: Optimize strlen-avx2.S
> >=20
> > * memchr is not yet fixed in master
> memchr should be fine in master.

It is not see:

https://sourceware.org/git/?p=3Dglibc.git;a=3Dblob;f=3Dsysdeps/x86_64/multi=
arch/ifunc-impl-list.c;h=3Da71444eccb3cb7cf59775408b3b2524397aaa2ec;hb=3DHE=
AD#l71

There are many more issues on master, so I am reopening the bug. I'll send a
patch series fixing the issues. Once this is fixed in master, we can proceed
with fixing the stable branches.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=