From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 0F527385DC2F; Mon, 31 Oct 2022 13:54:45 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0F527385DC2F
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1667224486;
	bh=6HBsTzw8ALxRkCYEgg8yf3miQY8OaRqXczbYSawftLI=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=f34j0ftftU5ik4kA7m/+UXSr2++AtrGgBqRAzTMz1H8fzmX5JwfyHIsK53yCSs3Hs
	 2iyT4BrSj849ITL5SAHeOxxstDnjkyzcfgyzrArDRWlBs/wjhpBQaxUEBU3Ug5z2qq
	 L6V66+CXmB8LdGJ3zlAzTrPnaldsIphSnQ/oqrYk=
From: "adhemerval.zanella at linaro dot org"
 <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/29730] broken y2038 support in fstatat on MIPS N64
Date: Mon, 31 Oct 2022 13:54:37 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: glibc
X-Bugzilla-Component: libc
X-Bugzilla-Version: 2.35
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: adhemerval.zanella at linaro dot org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-29730-131-Ks0vtnYgqB@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-29730-131@http.sourceware.org/bugzilla/>
References: <bug-29730-131@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <glibc-bugs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D29730

--- Comment #16 from Adhemerval Zanella <adhemerval.zanella at linaro dot o=
rg> ---
(In reply to YunQiang Su from comment #13)
> (In reply to Adhemerval Zanella from comment #7)
> > So MIPS ABI idiocrasies strike again.  What about:
> >=20
> > diff --git a/include/time.h b/include/time.h
> > index 20abea69d4..d3aff01aaa 100644
> > --- a/include/time.h
> > +++ b/include/time.h
> > @@ -2,6 +2,7 @@
> >  #include <time/time.h>
> >=20
> >  #ifndef _ISOMAC
> > +# include <time64-compat.h>
> >  # include <bits/types/struct_timeval.h>
> >  # include <struct___timespec64.h>
> >  # include <struct___timeval64.h>
> > @@ -344,12 +345,18 @@ libc_hidden_proto (__time64)
> >     actual clock ID.  */
> >  #define CLOCK_IDFIELD_SIZE     3
> >=20
> > -/* Check whether T fits in int32_t, assume all usages are for
> > -   sizeof(time_t) =3D=3D 32.  */
> > +/* Used on 32 to 64 bit time_t routines to check whether T fits in the
> > +   default time_t.  Some ABIs might still have 64 bit time_t as defaul=
t,
> > +   however with different layout for input/output arguments (for insta=
nce
> > +   fstatat/fstatat64 for mips64).  */
> >  static inline bool
> >  in_time_t_range (__time64_t t)
> >  {
> > +#ifdef TIME64_NON_DEFAULT
> >    int32_t s =3D t;
> > +#else
> > +  time_t s =3D t;
> > +#endif
> >    return s =3D=3D t;
> >  }
>=20
> sysdeps/generic/time64-compat.h says:
>=20
> /* Header included by Versions to generate the 64-bit time_t compat symbo=
ls.
>    Legacy ABIs with default 32-bit time support define TIME64_NON_DEFAULT=
 to
>    generate the 64-bit symbols.  */
>=20
> So, I don't think that rv32 and OpenRISC should define TIME64_NON_DEFAULT.

They do not, both uses 64 bit time_t as default.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=