[Bug libc/29730] broken y2038 support in fstatat on MIPS N64

["adhemerval.zanella at linaro dot org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=29730

--- Comment #15 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
(In reply to YunQiang Su from comment #12)
> (In reply to YunQiang Su from comment #11)
> > (In reply to Adhemerval Zanella from comment #10)
> > > (In reply to Aurelien Jarno from comment #9)
> > > > (In reply to YunQiang Su from comment #6)
> > > > > It seems that the altering of in_time_t_range to in fact int32_t,  also
> > > > > breaks something like 
> > > > >     __clock_adjtime
> > > > > on all 64bit system.
> > > > 
> > > > Do you have more details about that? Do you mean all 64-bit systems
> > > > including MIPS and non-MIPS? In that case the patch from Adhemerval would
> > > > not fix everything.
> > > 
> > > The stat on MIPS is an outlier (as everything for mips it seems) where the
> > > userland non-LFS struct stat defers from LFS struct stat.
> > 
> > Yes. It is quite annoying.
> > I am try to switch mips N64 to XSTAT_IS_XSTAT64.
> 
> Ohh, it seems impossible.

The XSTAT_IS_XSTAT64 is used by MIPS to advertise the kernel struct fstat have
different layouts from userland (an unfortunate MIPS ABI quick) as documented
briefly on sysdeps/unix/sysv/linux/mips/kernel_stat.h.

At least the LFS and non-LFS version have the same semantic, so we do not
actually need to provide different implementations for mips64. Maybe it would
be better to provide another macro, STAT_IS_STAT64, to make mips alias non-LFS
and LFS.

-- 
You are receiving this mail because:
You are on the CC list for the bug.