From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 77013385559C; Mon, 31 Oct 2022 17:01:48 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 77013385559C
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1667235708;
	bh=wFG3ZmZtuGGhXPClwEyYK1kbckmyROR0itS3rkvdeT8=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=uODRTVRU6RsGdk/9JJjmZHtg36Zm+CSnnCuEcEPdT0EepSoI8e8KyLFTvoICDnvQL
	 oZ7dRIt2lw5nfGQTsLlRNns7qJEC8KNNCxMtEUIX6xABMwJzVD9WludcPcIvT9Ac2h
	 ss5NskegV8HDbDlehHOlF6JkZ1yxGgm0NPEDGP/A=
From: "syq at debian dot org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug libc/29730] broken y2038 support in fstatat on MIPS N64
Date: Mon, 31 Oct 2022 17:01:47 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: glibc
X-Bugzilla-Component: libc
X-Bugzilla-Version: 2.35
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: syq at debian dot org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-29730-131-vqwPhUqdbF@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-29730-131@http.sourceware.org/bugzilla/>
References: <bug-29730-131@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <glibc-bugs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D29730

--- Comment #18 from YunQiang Su <syq at debian dot org> ---
(In reply to Adhemerval Zanella from comment #15)
> (In reply to YunQiang Su from comment #12)
> > (In reply to YunQiang Su from comment #11)
> > > (In reply to Adhemerval Zanella from comment #10)
> > > > (In reply to Aurelien Jarno from comment #9)
> > > > > (In reply to YunQiang Su from comment #6)
> > > > > > It seems that the altering of in_time_t_range to in fact int32_=
t,  also
> > > > > > breaks something like=20
> > > > > >     __clock_adjtime
> > > > > > on all 64bit system.
> > > > >=20
> > > > > Do you have more details about that? Do you mean all 64-bit syste=
ms
> > > > > including MIPS and non-MIPS? In that case the patch from Adhemerv=
al would
> > > > > not fix everything.
> > > >=20
> > > > The stat on MIPS is an outlier (as everything for mips it seems) wh=
ere the
> > > > userland non-LFS struct stat defers from LFS struct stat.
> > >=20
> > > Yes. It is quite annoying.
> > > I am try to switch mips N64 to XSTAT_IS_XSTAT64.
> >=20
> > Ohh, it seems impossible.
>=20
> The XSTAT_IS_XSTAT64 is used by MIPS to advertise the kernel struct fstat
> have different layouts from userland (an unfortunate MIPS ABI quick) as
> documented briefly on sysdeps/unix/sysv/linux/mips/kernel_stat.h.
>=20

The reason that MIPS N64 cannot use XSTAT_IS_XSTAT64 is due to the differen=
ce
between
   struct stat
   struct stat64
Although both of them support large file and 64bit time, while they have
different padding. Brain damaged design.


> At least the LFS and non-LFS version have the same semantic, so we do not
> actually need to provide different implementations for mips64. Maybe it
> would be better to provide another macro, STAT_IS_STAT64, to make mips al=
ias
> non-LFS and LFS.

Oh, no, we cannot define STAT_IS_STAT64 for MIPS N64.
Since it will broken binary compatible.

   struct stat
   struct stat64

is different!

--=20
You are receiving this mail because:
You are on the CC list for the bug.=