public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sourceware.org Subject: [Bug libc/29770] prctl does not match manual page ABI on powerpc64le-linux-gnu Date: Sat, 17 Feb 2024 08:17:19 +0000 [thread overview] Message-ID: <bug-29770-131-bzMyjlXEIs@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-29770-131@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=29770 --- Comment #4 from Sourceware Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Florian Weimer <fw@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=6a04404521ac4119ae36827eeb288ea84eee7cf6 commit 6a04404521ac4119ae36827eeb288ea84eee7cf6 Author: Florian Weimer <fweimer@redhat.com> Date: Sat Feb 17 09:17:04 2024 +0100 Linux: Switch back to assembly syscall wrapper for prctl (bug 29770) Commit ff026950e280bc3e9487b41b460fb31bc5b57721 ("Add a C wrapper for prctl [BZ #25896]") replaced the assembler wrapper with a C function. However, on powerpc64le-linux-gnu, the C variadic function implementation requires extra work in the caller to set up the parameter save area. Calling a function that needs a parameter save area without one (because the prototype used indicates the function is not variadic) corrupts the caller's stack. The Linux manual pages project documents prctl as a non-variadic function. This has resulted in various projects over the years using non-variadic prototypes, including the sanitizer libraries in LLVm and GCC (GCC PR 113728). This commit switches back to the assembler implementation on most targets and only keeps the C implementation for x86-64 x32. Also add the __prctl_time64 alias from commit b39ffab860cd743a82c91946619f1b8158b0b65e ("Linux: Add time64 alias for prctl") to sysdeps/unix/sysv/linux/syscalls.list; it was not yet present in commit ff026950e280bc3e9487b41b460fb31bc5b57721. This restores the old ABI on powerpc64le-linux-gnu, thus fixing bug 29770. Reviewed-By: Simon Chopin <simon.chopin@canonical.com> -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2024-02-17 8:17 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-10 8:36 [Bug libc/29770] New: " fweimer at redhat dot com 2022-11-10 8:44 ` [Bug libc/29770] " fweimer at redhat dot com 2022-11-10 8:45 ` sam at gentoo dot org 2022-11-10 16:28 ` fweimer at redhat dot com 2024-02-02 18:38 ` fweimer at redhat dot com 2024-02-02 18:46 ` fweimer at redhat dot com 2024-02-02 21:28 ` fweimer at redhat dot com 2024-02-02 21:31 ` fweimer at redhat dot com 2024-02-05 9:37 ` fweimer at redhat dot com 2024-02-17 8:17 ` cvs-commit at gcc dot gnu.org [this message] 2024-02-17 8:27 ` fweimer at redhat dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-29770-131-bzMyjlXEIs@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).