From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 24FB33858D39; Tue, 28 Mar 2023 05:02:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 24FB33858D39 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1679979775; bh=yc72upf5claN1N5GByUUscM7N1UsHQdHwFa4tx+ee2g=; h=From:To:Subject:Date:In-Reply-To:References:From; b=v+HxpQnwjQbVogetbepKjARM0VPGSnN7NnMN+4AgFHjCIGQv/3+Imf6hqXrh9hLQY PAa18B+JTVTFx43TQyd5Ebt/d+7TjuhLDQPtEoGvGwkcWfUq/CKuRFob5sElyzyPqC +5iULra9VytXNyn6DgEMrRPzqyOmH2cTzaN2yLIQ= From: "stsp at users dot sourceforge.net" To: glibc-bugs@sourceware.org Subject: [Bug dynamic-link/30007] rfe: dlopen to specified address Date: Tue, 28 Mar 2023 05:02:54 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: dynamic-link X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: stsp at users dot sourceforge.net X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30007 --- Comment #25 from Stas Sergeev --- For example the diffstat of the largest patch that actually implements dlmem, is: 48 files changed, 484 insertions(+), 1 deletion(-) 1 deletion! (in a makefile) And another patch that adds the optional part of dlmem, looks like this: 5 files changed, 202 insertions(+), 2 deletions(-) 2 deletions in a makefile. You probably can't ask for the better changes separation: the 2 main patches change no existing code at all. Yes, there are also 2 patches with diffstats under 200 lines, but if the indentation is ignored, then they are 20 lines. The rest of the patches are in a range of 10-50 lines. Not sure if any better separation is possible. > Your patch is difficult to review for reasons that have to do with the API What does this mean? We can discuss API also here if the patch makes it somehow difficult. --=20 You are receiving this mail because: You are on the CC list for the bug.=