From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id AD47D3858425; Thu, 9 Feb 2023 12:48:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AD47D3858425 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1675946929; bh=ZMPXi3uP45a2Af/TB8WagFTelNQQzlLXSJmLnfyATFo=; h=From:To:Subject:Date:In-Reply-To:References:From; b=MLfxNN2aL2OKkTC/h5hRuTd+dep028AUlGcEqegAj0PQYuPDtPY/9bX/w0ZbXcC92 zw6yhbfl0YerDRcMHdnyq+/BTPgWdFVY8Dt01VF1oCF62Uioeq8Uua/bwdTt+Yc0YE UgSAMCOiBgZguT05xqAcyvrbqs78lXRKoAnJKUnc= From: "adhemerval.zanella at linaro dot org" To: glibc-bugs@sourceware.org Subject: [Bug dynamic-link/30100] [patch] add dlmem() Date: Thu, 09 Feb 2023 12:48:49 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: dynamic-link X-Bugzilla-Version: 2.38 X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: adhemerval.zanella at linaro dot org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30100 --- Comment #4 from Adhemerval Zanella --- (In reply to Stas Sergeev from comment #3) > But as indicated above, I have problems running this patch > through the test-suit. All built tests use the system-wide > elf interpreter, so after I changed the "struct rtld_global_ro" > I have to use patchelf on a test binaries to set the interpreter > to the newly-built one. > Please tell me how to solve that problem, because of course > running through the test-suit is a requirement for submission > to the mail list. >=20 The glibc testsuite has tests that either run through the built loader and libraries (by invoking the loader directly with --library-path or by buildi= ng the tests to use the build loader when configure with --enable-hardcoded-path-in-tests) or use a minimal container (where you can override system-wide configuration). You can also test a binary with the gl= ibc loader by using the 'testrun.sh' script in the build folder. The former is the default for tests, while the latter requires some extra c= are (check the tests-container tests on Makefiles). So first thing you would like to check is whether the new patch adds any regression by running 'make check'. Then you need to add any extra tests to exercise the new feature, if they require changing any global state (such as global files, etc.) it is preferable to provide them as tests-containers. > Please let me know if there are any alternatives, too, like > eg donating on patreon to someone who can do the remaining work. --=20 You are receiving this mail because: You are on the CC list for the bug.=