public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug dynamic-link/30125] [regression, bisected] glibc-2.37 creates new symlink for libraries without soname
Date: Mon, 20 Feb 2023 16:32:29 +0000	[thread overview]
Message-ID: <bug-30125-131-gwalIP7HyM@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30125-131@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=30125

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The release/2.37/master branch has been updated by Adhemerval Zanella
<azanella@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=590d0e089b06f158ded713f5e5600eaa66dcea44

commit 590d0e089b06f158ded713f5e5600eaa66dcea44
Author: Joan Bruguera <joanbrugueram@gmail.com>
Date:   Sat Feb 18 21:52:15 2023 +0000

    elf: Restore ldconfig libc6 implicit soname logic [BZ #30125]

    While cleaning up old libc version support, the deprecated libc4 code was
    accidentally kept in `implicit_soname`, instead of the libc6 code.

    This causes additional symlinks to be created by `ldconfig` for libraries
    without a soname, e.g. a library `libsomething.123.456.789` without a
soname
    will create a `libsomething.123` -> `libsomething.123.456.789` symlink.

    As the libc6 version of the `implicit_soname` code is a trivial `xstrdup`,
    just inline it and remove `implicit_soname` altogether.

    Some further simplification looks possible (e.g. the call to `create_links`
    looks like a no-op if `soname == NULL`, other than the verbose printfs),
but
    logic is kept as-is for now.

    Fixes: BZ #30125
    Fixes: 8ee878592c4a ("Assume only FLAG_ELF_LIBC6 suport")
    Signed-off-by: Joan Bruguera <joanbrugueram@gmail.com>

    Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
    (cherry picked from commit 1b0ea8c5d886fedabd611a569b5ec58a6f5153e6)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

      parent reply	other threads:[~2023-02-20 16:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-15  0:22 [Bug dynamic-link/30125] New: [regression, bisected] glibc-2.37 creates new symlink created in " joanbrugueram at gmail dot com
2023-02-15  0:22 ` [Bug dynamic-link/30125] [regression, bisected] glibc-2.37 creates new symlink created " joanbrugueram at gmail dot com
2023-02-15  0:23 ` [Bug dynamic-link/30125] [regression, bisected] glibc-2.37 creates new symlink " joanbrugueram at gmail dot com
2023-02-15  0:23 ` joanbrugueram at gmail dot com
2023-02-15  0:34 ` joanbrugueram at gmail dot com
2023-02-15  9:21 ` sam at gentoo dot org
2023-02-20 12:35 ` cvs-commit at gcc dot gnu.org
2023-02-20 12:36 ` adhemerval.zanella at linaro dot org
2023-02-20 16:32 ` cvs-commit at gcc dot gnu.org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30125-131-gwalIP7HyM@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).