public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "stli at linux dot ibm.com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sourceware.org
Subject: [Bug math/30130] [s390] The _FPU_SETCW macro yields compile error with Clang
Date: Tue, 28 Feb 2023 12:21:43 +0000	[thread overview]
Message-ID: <bug-30130-131-OOACTeP766@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30130-131@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=30130

--- Comment #2 from Stefan Liebler <stli at linux dot ibm.com> ---
Hi Andreas,

I've successfully tested your patch with gcc/binutils. And also double checked
that your example builds with clang.

In glibc the spurious second operand was already used when the file
fpu_control.h was introduced back in 2000.

As information, the instructions efpc/sfpc really have no second operand, which
is reflected in binutils commit from 2007 which should be landed in binutils
2.18:
https://github.com/bminor/binutils-gdb/commit/b8e558488cb3c85687107ef81b2504fac0c11a6b
There is also this comment:
/* Actually efpc and sfpc do not take an optional operand.
   This is just a workaround for existing code e.g. glibc.  */

Note: glibc-upstream currently requires binutils 2.25 or newer. Thus we can
just remove the second operand in glibc.

Please post your patch to libc-alpha@sourceware.org and add "[BZ #30130]" to
the subject. Then I will commit it and close this bugzilla.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2023-02-28 12:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16 16:26 [Bug math/30130] New: " arnez at linux dot ibm.com
2023-02-16 16:28 ` [Bug math/30130] " arnez at linux dot ibm.com
2023-02-16 16:38 ` arnez at linux dot ibm.com
2023-02-28 12:21 ` stli at linux dot ibm.com [this message]
2023-02-28 13:05 ` stli at linux dot ibm.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30130-131-OOACTeP766@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).