public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "fw at deneb dot enyo.de" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sourceware.org Subject: [Bug dynamic-link/30428] New: New AMD cache size computation logic does not work for some CPUs, hypervisors Date: Mon, 08 May 2023 16:42:13 +0000 [thread overview] Message-ID: <bug-30428-131@http.sourceware.org/bugzilla/> (raw) https://sourceware.org/bugzilla/show_bug.cgi?id=30428 Bug ID: 30428 Summary: New AMD cache size computation logic does not work for some CPUs, hypervisors Product: glibc Version: 2.38 Status: NEW Severity: critical Priority: P1 Component: dynamic-link Assignee: unassigned at sourceware dot org Reporter: fw at deneb dot enyo.de Target Milestone: --- Flags: security- This commit: commit 103a469dc7755fd9e8ccf362f3dd4c55dc761908 Author: Sajan Karumanchi <sajan.karumanchi@amd.com> Date: Wed Jan 18 18:29:04 2023 +0100 x86: Cache computation for AMD architecture. All AMD architectures cache details will be computed based on __cpuid__ `0x8000_001D` and the reference to __cpuid__ `0x8000_0006` will be zeroed out for future architectures. Reviewed-by: Premachandra Mallappa <premachandra.mallappa@amd.com> changed cache size computation on the AMD architecture. However, the new way of doing things is not supported by all AMD CPUs. This CPU: processor : 0 vendor_id : AuthenticAMD cpu family : 16 model : 6 model name : AMD Turion(tm) II Neo N40L Dual-Core Processor stepping : 3 microcode : 0x10000c8 cpu MHz : 800.000 cache size : 1024 KB physical id : 0 siblings : 2 core id : 0 cpu cores : 2 apicid : 0 initial apicid : 0 fpu : yes fpu_exception : yes cpuid level : 5 wp : yes flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm 3dnowext 3dnow constant_tsc rep_good nopl nonstop_tsc cpuid extd_apicid pni monitor cx16 popcnt lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw ibs skinit wdt nodeid_msr hw_pstate vmmcall npt lbrv svm_lock nrip_save bugs : tlb_mmatch apic_c1e fxsave_leak sysret_ss_attrs null_seg amd_e400 spectre_v1 spectre_v2 bogomips : 2995.32 TLB size : 1024 4K pages clflush size : 64 cache_alignment : 64 address sizes : 48 bits physical, 48 bits virtual power management: ts ttp tm stc 100mhzsteps hwpstate reports all zeros for its caches after this change (build from commit cea74a4a24c36202309e8254f1f938e2166488f3, which includes commit mentioned above): $ ./ld.so --list-diagnostics | grep -E 'level|threshold' x86.cpu_features.non_temporal_threshold=0x4040 x86.cpu_features.rep_movsb_threshold=0x800 x86.cpu_features.rep_movsb_stop_threshold=0x0 x86.cpu_features.rep_stosb_threshold=0x800 x86.cpu_features.level1_icache_size=0x0 x86.cpu_features.level1_icache_linesize=0x0 x86.cpu_features.level1_dcache_size=0x0 x86.cpu_features.level1_dcache_assoc=0x0 x86.cpu_features.level1_dcache_linesize=0x0 x86.cpu_features.level2_cache_size=0x0 x86.cpu_features.level2_cache_assoc=0x0 x86.cpu_features.level2_cache_linesize=0x0 x86.cpu_features.level3_cache_size=0x0 x86.cpu_features.level3_cache_assoc=0x0 x86.cpu_features.level3_cache_linesize=0x0 x86.cpu_features.level4_cache_size=0xffffffffffffffff A build from the 2.36 branch (commit b7008a92f505632f32b313d1033d6d15c99a0b31) yields this instead: $ ./ld.so --list-diagnostics | grep -E 'level|threshold' x86.cpu_features.non_temporal_threshold=0xc0000 x86.cpu_features.rep_movsb_threshold=0x800 x86.cpu_features.rep_movsb_stop_threshold=0x100000 x86.cpu_features.rep_stosb_threshold=0x800 x86.cpu_features.level1_icache_size=0x10000 x86.cpu_features.level1_icache_linesize=0x40 x86.cpu_features.level1_dcache_size=0x10000 x86.cpu_features.level1_dcache_assoc=0x2 x86.cpu_features.level1_dcache_linesize=0x40 x86.cpu_features.level2_cache_size=0x100000 x86.cpu_features.level2_cache_assoc=0x10 x86.cpu_features.level2_cache_linesize=0x40 x86.cpu_features.level3_cache_size=0x0 x86.cpu_features.level3_cache_assoc=0x0 x86.cpu_features.level3_cache_linesize=0x0 x86.cpu_features.level4_cache_size=0xffffffffffffffff So it's a regression. The CPU is probably old enough that we don't use temporal stores, so there is probably not going to be a crash in glibc. But lack of accurate cache sizes probably still causes performance regressions elsewhere (although no one is going to use CPUs that old for their performance, admittedly). Some hypervisors also fail to pass through these CPUID values even if they identify the CPU as an AMD model: https://bugzilla.redhat.com/show_bug.cgi?id=2196271 Addressing hypervisor compatibility might be the important part here. -- You are receiving this mail because: You are on the CC list for the bug.
next reply other threads:[~2023-05-08 16:42 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-08 16:42 fw at deneb dot enyo.de [this message] 2023-05-08 17:03 ` [Bug dynamic-link/30428] " fweimer at redhat dot com 2023-05-08 17:09 ` fweimer at redhat dot com 2023-05-08 20:29 ` fweimer at redhat dot com 2023-05-09 14:55 ` jamborm at gcc dot gnu.org 2023-06-11 17:52 ` sam at gentoo dot org 2023-07-04 17:34 ` fweimer at redhat dot com 2023-09-14 20:33 ` jamborm at gcc dot gnu.org 2023-09-14 20:48 ` fweimer at redhat dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-30428-131@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).